stream_context_set_option(): fix incorrect parameter name #4945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I vaguely remember these signatures are normally updated automatically from the stub files ? Not sure what happened here, but this one is clearly wrong. Page: https://www.php.net/manual/en/function.stream-context-set-option.php Signature as per the stub: https://github.com/php/php-src/blob/40a42cffd81b7f01fed25b3f7d02cb4d2ead700d/ext/standard/basic_functions.stub.php#L3384C78-L3384C103
They can be updated automatically, but it's still a manual process to start the automated update. |
And this may be one of the functions which is exempt from the auto-update anyway as it's one of the ones with a (deprecated) alternative signature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I vaguely remember these signatures are normally updated automatically from the stub files ? Not sure what happened here, but this one is clearly wrong.
Page: https://www.php.net/manual/en/function.stream-context-set-option.php
Signature as per the stub: https://github.com/php/php-src/blob/40a42cffd81b7f01fed25b3f7d02cb4d2ead700d/ext/standard/basic_functions.stub.php#L3384C78-L3384C103