uri: Preinitialize errors array with the correct size in fill_errors()#21560
Merged
TimWolla merged 1 commit intophp:masterfrom Mar 28, 2026
Merged
uri: Preinitialize errors array with the correct size in fill_errors()#21560TimWolla merged 1 commit intophp:masterfrom
errors array with the correct size in fill_errors()#21560TimWolla merged 1 commit intophp:masterfrom
Conversation
TimWolla
approved these changes
Mar 28, 2026
TimWolla
changed the title
fill_errors()errors array with the correct size in fill_errors()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we already could get length from
lexbor_plog_length(lexbor_parser.log), we could directly usearray_init_size(errors, len)instead ofarray_init(errors)