Skip to content

uri: Preinitialize errors array with the correct size in fill_errors() #21560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimWolla merged 1 commit into from
Mar 28, 2026
Merged

uri: Preinitialize errors array with the correct size in fill_errors() #21560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ext/uri/uri_parser_whatwg.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,13 @@ static zend_always_inline void zval_long_or_null_to_lexbor_str(zval *value, lexb
*/
static const char *fill_errors(zval *errors)
{
if (lexbor_parser.log == NULL || lexbor_plog_length(lexbor_parser.log) == 0) {
size_t log_len;
if (lexbor_parser.log == NULL || (log_len = lexbor_plog_length(lexbor_parser.log)) == 0) {
ZVAL_EMPTY_ARRAY(errors);
return NULL;
}

array_init(errors);
array_init_size(errors, log_len);
const char *result = NULL;

lexbor_plog_entry_t *lxb_error;
Expand Down
Loading