Disallow newlines in CURLOPT_HTTPHEADER#22651
Open
Sjord wants to merge 4 commits into
Open
Conversation
It was possible to have multiple lines in a HTTP headers in a cURL request, which then get interpreted as multiple headers. This commit changes that to throw a ValueError when using newlines or carriage returns in a string passed as header.
Author
TimWolla
reviewed
Jul 9, 2026
Based on PR review comments. I'll do the NUL byte check separately.
This is already done for string options in php_curl_option_str (see bug #68089). Similarly, array arguments should also not contain NUL bytes, so we throw the same error for these.
TimWolla
reviewed
Jul 9, 2026
And add test case
TimWolla
approved these changes
Jul 9, 2026
TimWolla
left a comment
TimWolla
left a comment
Member
There was a problem hiding this comment.
LGTM, but there were some concerns raised on the mailing list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was possible to have multiple lines in a HTTP headers in a cURL request, which then get interpreted as multiple headers. This commit changes that to throw a ValueError when using newlines or carriage returns in a string passed as header.