date: Correctly handle Duration::__construct() calls - #23098
Merged
TimWolla merged 1 commit intoAug 7, 2026
Conversation
TimWolla
referenced
this pull request
Aug 7, 2026
* date: Add `Time\Duration` RFC: https://wiki.php.net/rfc/duration_class * date: Cache the most recently `Time\Duration` object created with `from*()` This is useful for patterns like the following: for (;;) { $watchers = $poll->wait(Time\Duration::fromSeconds(1)); // … } which is repeatedly creating identical duration objects for every loop iteration. * date: Add `Z_PARAM_ULONG()` helper to `time_duration.c` * date: Make `tests/time/duration/helper.inc` compatible with PHP < 8.6 This will allow polyfills to more easily consume the upstream tests. * NEWS / UPGRADING Co-authored-by: Tim Düsterhus <tim@bastelstu.be>
Co-authored-by: Nora Dossche <7771979+ndossche@users.noreply.github.com>
TimWolla
force-pushed
the
time-duration-reflection-invoke-construct
branch
from
August 7, 2026 11:11
af4b5e3 to
0a3b1ae
Compare
ndossche
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.