ext/uri: Consistency follow up to #23286 - #23551
Draft
NickSdot wants to merge 39 commits into
Draft
Conversation
Co-authored-by: Máté Kocsis <kocsismate90@gmail.com>
This test was sourced from gh22046.phpt which first was renamed and moved, then reverted. This adjusts the naming. Part of the test is now in both. Reason: should not remove the test case here just because a bug test has it as well.
NickSdot
commented
Sep 3, 2026
| --FILE-- | ||
| <?php | ||
|
|
||
| $url = Uri\WhatWg\Url::parse("foo://example.com"); |
Contributor
Author
There was a problem hiding this comment.
Was exact duplicate of host_error_forbidden_host_codepoint_special2.phpt (now host_error_colon_special.phpt); I assume the intention was to test the same as in the special tests, so I did that.
NickSdot
commented
Sep 3, 2026
| @@ -1,5 +1,5 @@ | |||
| --TEST-- | |||
| Test Uri\WhatWg\Url component modification - error - modifying multiple components with warnings before throwing an exception | |||
| Test Uri\WhatWg\Url component modification - error - earlier warnings not in exception | |||
Contributor
Author
There was a problem hiding this comment.
Here no method added. Although withScheme() is used this is testing that warnings aren't carried over -- so I did not see that as method specific?
NickSdot
commented
Sep 3, 2026
| @@ -1,5 +1,5 @@ | |||
| --TEST-- | |||
| Test Uri\Rfc3986\Uri component modification - port - too small number | |||
| Test Uri\Rfc3986\Uri::withPort() - error - negative number | |||
Contributor
Author
There was a problem hiding this comment.
Elsewhere either "negative value" or "negative number" was used. Here we have (int) -1 so negative number should be correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: #23286; as requested in #23286 (comment). Usable diff here until 23286 is merged and here rebased.
cc @kocsismate
Edit: failure unrelated