Fix missing “Copy” button on the Windows download page - #1981
Merged
Conversation
LamentXU123
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
August 3, 2026 06:03
Contributor
|
📊 Regression report for commit 2dd7b70 is at https://web-php-regression-report-pr-1981.preview.thephp.foundation |
Contributor
|
🚀 Preview for commit 2dd7b70 is available at https://web-php-pr-1981.preview.thephp.foundation |
sy-records
requested changes
Aug 4, 2026
| if (!isset($src["filename"])) { | ||
| continue; | ||
| } | ||
| printf('<li><a href="https://museum.php.net/php%d/%s">%s</a></li>', |
Member
There was a problem hiding this comment.
These don't have SHA-256 hashes, only MD5, so the changes made here are unnecessary and need to be reverted.
Member
Author
There was a problem hiding this comment.
I dont see the reason why we only provide a button in case of SHA1 but not MD5.
Member
There was a problem hiding this comment.
Most of them are SHA-256; I've already removed MD5 from my PR. These MD5 values may simply be legacy issues.
Member
Author
There was a problem hiding this comment.
Oh I see. Fair point :)
LamentXU123
changed the title
LamentXU123
changed the title
sy-records
approved these changes
Aug 4, 2026
sy-records
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Copy buttons next to SHA256 checksums on download-related pages. Follow-up #1957. Now not only in the pre-realese page do we have this button after sha1 hash.
cc @sy-records