Skip to content

Update each branch's release topic from its own latest revision - #454

Open
ECYaz wants to merge 2 commits into
phpbb:3.3.xfrom
ECYaz:fix/373-release-topic-per-branch
Open

Update each branch's release topic from its own latest revision#454
ECYaz wants to merge 2 commits into
phpbb:3.3.xfrom
ECYaz:fix/373-release-topic-per-branch

Conversation

@ECYaz

@ECYaz ECYaz commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

The release topic update built one post body from the highest branch's latest download and applied it to every branch's topic.

For example, with a style supporting both 3.2 and 3.3:

  1. The author releases 1.2.0 for 3.2 and 3.3. Both branches' release topics correctly show 1.2.0.
  2. The author later releases 1.6.0 for 3.2 only. On approval, update_release_topic() takes the first download entry, which belongs to the highest branch: 3.3, still on 1.2.0. That revision lists both branches, so both first posts are rebuilt from it, and the 3.2 topic goes back to advertising 1.2.0 and its download link while the reply below it announces "Style Updated to version 1.6.0, See first post for Download Link".
  3. Had the 3.3 branch's latest revision been 3.3-only instead, the loop would never visit 3.2 at all: the 3.2 first post would simply never update, and a branch whose revisions are never shared with the highest branch never gets a release topic created in the first place.

The first post is now rebuilt per branch from that branch's own latest approved revision, which also creates the release topic for a branch whose revision is not shared with the highest branch.

Fixes #373

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes release-topic updates so each phpBB branch’s release topic is rebuilt from that branch’s own latest approved revision/download, preventing outdated first-post content when branches advance independently (Fixes #373).

Changes:

  • Update update_release_topic() to iterate per-branch downloads instead of using only the highest-branch download as the source for all topics.
  • Derive the tested phpBB version for the specific branch from the revision’s phpbb_versions rows before rendering the first-post body.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread includes/objects/contribution.php
A revision that is the latest for several branches collapsed to a single entry when the list was keyed through array_flip, so consumers indexing by branch lost every branch but one: the release topic loop skipped a branch's topic, the demo box dropped a branch, and the version check reported one branch only. The list now carries one entry per branch, revisions shared between branches are shown once in the download details, and the approved branches fallback resolves branches without the flip.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong extension version number and phpBB version

2 participants