[ticket/17472] Prevent web push fatal error when there are no users to notify#7006
Closed
ECYaz wants to merge 1 commit into
Closed
[ticket/17472] Prevent web push fatal error when there are no users to notify#7006ECYaz wants to merge 1 commit into
ECYaz wants to merge 1 commit into
Conversation
…o notify notify_using_webpush() ran sql_in_set() with an empty array when removing banned users left nobody to notify, triggering a fatal "No values specified for SQL IN comparison" error. Return early and empty the queue instead. PHPBB-17472
Member
|
This is duplicating a fix in #6961 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17472
Web push fataled with "No values specified for SQL IN comparison" when removing banned users left nobody to notify. The queue is now emptied and skipped instead.