Skip to content

Fix #4524: Add missing 0 initial on the "Users overview". - #1354

Merged
Tithugues merged 1 commit into
phpmyadmin:QA_4_2from
Tithugues:b4524_q42
Sep 7, 2014
Merged

Fix #4524: Add missing 0 initial on the "Users overview".#1354
Tithugues merged 1 commit into
phpmyadmin:QA_4_2from
Tithugues:b4524_q42

Conversation

@Tithugues

Copy link
Copy Markdown
Contributor

See http://sourceforge.net/p/phpmyadmin/bugs/4524/

Even if a user initial is 0, the 0 is not in the initials list.
This PR should fix this and display the 0 in the list.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.0%) when pulling 2cbbf5a on Tithugues:b4524_q42 into e1664a3 on phpmyadmin:QA_4_2.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.0%) when pulling 92e34f0 on Tithugues:b4524_q42 into e1664a3 on phpmyadmin:QA_4_2.

@lem9

lem9 commented Sep 7, 2014

Copy link
Copy Markdown
Contributor

The initial appears but does not work.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
@Tithugues

Copy link
Copy Markdown
Contributor Author

Marc,
Thanks for your feedback. I updated my branch.

@lem9

lem9 commented Sep 7, 2014

Copy link
Copy Markdown
Contributor

Works great now.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling 451ece0 on Tithugues:b4524_q42 into e1664a3 on phpmyadmin:QA_4_2.

@scrutinizer-notifier

Copy link
Copy Markdown

The inspection completed: 3 new issues, 3 updated code elements

Tithugues added a commit that referenced this pull request Sep 7, 2014
Fix #4524: Add missing 0 initial on the "Users overview".
@Tithugues
Tithugues merged commit 87b1cd1 into phpmyadmin:QA_4_2 Sep 7, 2014
@Tithugues
Tithugues deleted the b4524_q42 branch September 7, 2014 15:06
@Tithugues

Copy link
Copy Markdown
Contributor Author

Merge is done.
Could you please just confirm that the logs are ok?
Thanks.

@lem9

lem9 commented Sep 7, 2014

Copy link
Copy Markdown
Contributor

Everything is fine for both branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants