Modified CSS value font-size to revert instead of 1em.#16370
Merged
williamdes merged 1 commit intophpmyadmin:QA_5_1from Jan 23, 2021
Merged
Modified CSS value font-size to revert instead of 1em.#16370williamdes merged 1 commit intophpmyadmin:QA_5_1from
williamdes merged 1 commit intophpmyadmin:QA_5_1from
Conversation
williamdes
requested changes
Sep 20, 2020
Member
williamdes
left a comment
There was a problem hiding this comment.
Could you try another approach ?
Because https://caniuse.com/css-revert-value has poor support.
87cac6d to
73e470a
Compare
Contributor
Author
|
Changed from |
Member
We still need to support IE .. (https://github.com/phpmyadmin/phpmyadmin/blob/master/.browserslistrc#L9) |
Contributor
Author
|
ok |
|
Any ETA on when this fix will go live? It's very difficult to work with phpMyAdmin when the row's font size is so small. |
73e470a to
8628373
Compare
Contributor
Author
|
Fixed. |
MauricioFauth
approved these changes
Jan 14, 2021
Signed-off-by: Rajat Jain <rajatjain.ix@gmail.com>
Member
I agree I rebased the changes and applied the new font width only for textareas. |
williamdes
approved these changes
Jan 22, 2021
This comment has been minimized.
This comment has been minimized.
MauricioFauth
approved these changes
Jan 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Signed-off-by: Rajat Jain rajatjain.ix@gmail.com
Description
Please describe your pull request.
I have modified the property
font-sizefortextareato valuerevertinstead of1emin ALL themes.Fixes #16252
Before submitting pull request, please review the following checklist:
Signed-off-byline as described in our DCO. This ensures that the work you're submitting is your own creation.