Skip to content

Comments

Modified CSS value font-size to revert instead of 1em.#16370

Merged
williamdes merged 1 commit intophpmyadmin:QA_5_1from
rajat315315:fix-16252
Jan 23, 2021
Merged

Modified CSS value font-size to revert instead of 1em.#16370
williamdes merged 1 commit intophpmyadmin:QA_5_1from
rajat315315:fix-16252

Conversation

@rajat315315
Copy link
Contributor

Signed-off-by: Rajat Jain rajatjain.ix@gmail.com

Description

Please describe your pull request.
I have modified the property font-size for textarea to value revert instead of 1em in ALL themes.

Fixes #16252

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try another approach ?
Because https://caniuse.com/css-revert-value has poor support.

@rajat315315
Copy link
Contributor Author

Changed from revert to initial.

@williamdes
Copy link
Member

@rajat315315
Copy link
Contributor Author

ok

@rajat315315 rajat315315 changed the title 25Modified CSS value font-size to revert instead of 1em. Modified CSS value font-size to revert instead of 1em. Oct 22, 2020
@qcybb
Copy link

qcybb commented Oct 29, 2020

Any ETA on when this fix will go live?

It's very difficult to work with phpMyAdmin when the row's font size is so small.

@rajat315315
Copy link
Contributor Author

Fixed.

@qcybb
Copy link

qcybb commented Oct 29, 2020

I'm not sure you want to adjust input and select - only textarea. Adjusting the other 2 makes them look too big.

Setting only textarea to "font-size:1.3em" looks good over here.

github

@williamdes williamdes changed the base branch from QA_5_0 to master November 1, 2020 22:39
Signed-off-by: Rajat Jain <rajatjain.ix@gmail.com>
@williamdes williamdes changed the base branch from master to QA_5_1 January 22, 2021 23:23
@phpmyadmin phpmyadmin deleted a comment from phpmyadmin-bot Jan 22, 2021
@williamdes
Copy link
Member

I'm not sure you want to adjust input and select - only textarea. Adjusting the other 2 makes them look too big.

I agree

I rebased the changes and applied the new font width only for textareas.
Tested the fix and it makes sense, I will be merging this fix soon if anyone does comment against.

@williamdes williamdes added this to the 5.1.0 milestone Jan 22, 2021
@williamdes williamdes added the UI Issues relating to the user interface label Jan 22, 2021
@codecov

This comment has been minimized.

@williamdes williamdes self-assigned this Jan 23, 2021
@williamdes williamdes merged commit 5706548 into phpmyadmin:QA_5_1 Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI Issues relating to the user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Font size too small when editing rows

4 participants