Skip to content

Fixes #16805 Fixes shortcut keys#16807

Merged
williamdes merged 1 commit intophpmyadmin:QA_5_1from
shucon:Fix_16805
Apr 13, 2021
Merged

Fixes #16805 Fixes shortcut keys#16807
williamdes merged 1 commit intophpmyadmin:QA_5_1from
shucon:Fix_16805

Conversation

@shucon
Copy link
Copy Markdown
Contributor

@shucon shucon commented Apr 10, 2021

Signed-off-by: Saksham Gupta shucon01@gmail.com

Description

Please describe your pull request.

Fixes #16805

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
@shucon shucon changed the base branch from master to QA_5_1 April 10, 2021 20:20
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2021

Codecov Report

Merging #16807 (ce2f508) into QA_5_1 (dcb499e) will increase coverage by 3.30%.
The diff coverage is 40.78%.

Impacted file tree graph

@@             Coverage Diff              @@
##             QA_5_1   #16807      +/-   ##
============================================
+ Coverage     53.03%   56.34%   +3.30%     
+ Complexity    15201    15145      -56     
============================================
  Files           471      476       +5     
  Lines         63205    60815    -2390     
============================================
+ Hits          33521    34265     +744     
+ Misses        29684    26550    -3134     
Flag Coverage Δ Complexity Δ
dbase-extension 56.00% <41.33%> (+3.33%) 0.00 <12.00> (ø)
recode-extension 55.95% <41.33%> (+3.33%) 0.00 <12.00> (ø)
unit-7.1-ubuntu-latest ? ?
unit-7.2-ubuntu-latest 55.95% <41.33%> (+3.14%) 0.00 <12.00> (ø)
unit-7.3-ubuntu-latest 59.63% <42.46%> (+2.01%) 0.00 <12.00> (ø)
unit-7.4-ubuntu-latest 59.63% <42.46%> (+2.00%) 0.00 <12.00> (ø)
unit-8.0-ubuntu-latest 59.81% <41.89%> (+2.02%) 0.00 <12.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../classes/Controllers/Database/ExportController.php 0.00% <0.00%> (ø) 22.00 <0.00> (ø)
libraries/classes/Controllers/ExportController.php 0.00% <0.00%> (ø) 86.00 <0.00> (-1.00)
...es/classes/Controllers/Server/ExportController.php 0.00% <0.00%> (ø) 7.00 <0.00> (ø)
...ies/classes/Controllers/Table/ExportController.php 0.00% <0.00%> (ø) 18.00 <0.00> (ø)
libraries/classes/Core.php 64.14% <0.00%> (+0.35%) 192.00 <4.00> (+1.00)
libraries/classes/Database/Routines.php 40.96% <ø> (-10.97%) 240.00 <0.00> (-17.00)
libraries/classes/Database/Triggers.php 36.75% <0.00%> (+0.95%) 81.00 <0.00> (+1.00)
libraries/classes/Navigation/Navigation.php 93.65% <ø> (-0.71%) 29.00 <0.00> (ø)
libraries/classes/Plugins/Schema/Svg/Svg.php 72.30% <0.00%> (ø) 18.00 <1.00> (ø)
...s/Transformations/Output/Text_Plain_Binarytoip.php 25.00% <0.00%> (-2.28%) 7.00 <0.00> (+1.00) ⬇️
... and 354 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4afbc67...ce2f508. Read the comment docs.

@williamdes williamdes added this to the 5.1.1 milestone Apr 13, 2021
@williamdes williamdes self-assigned this Apr 13, 2021
@williamdes williamdes merged commit a4482fb into phpmyadmin:QA_5_1 Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shortcut keys don't work

2 participants