Skip to content

Conversation

@ibennetch
Copy link
Member

@ibennetch ibennetch commented Oct 14, 2025

Description

There are a lot of places where we reference when a feature was introduced, especially in the 2.x versions. I think it's unnecessary, adds extra length to the documentation, and sometimes makes us look outdated (because of references to something from 2010 as "new").

I'm working on removing those in preparation of the 6.0 release, but before I put a lot of work in to it wanted to show a sample of what's in progress to make sure everyone is in agreement about this change.

For example, here or here.

This is just a draft right now.

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

Comment on lines 744 to 790
with the ``/public/setup`` suffix. The changes are not saved to the server, you need to
use the :guilabel:`Download` button to save them to your computer and then upload
to the server.

Now the file is ready to be used. You can choose to review or edit the
file with your favorite editor, if you prefer to set some advanced
options that the setup script does not provide.

#. If you are using the ``auth_type`` "config", it is suggested that you
protect the phpMyAdmin installation directory because using config
does not require a user to enter a password to access the phpMyAdmin
installation. Use of an alternate authentication method is
recommended, for example with HTTP–AUTH in a :term:`.htaccess` file or switch to using
``auth_type`` cookie or http. See the :ref:`faqmultiuser`
for additional information, especially :ref:`faq4_4`.
#. Open the main phpMyAdmin directory in your browser.
phpMyAdmin should now display a welcome screen and your databases, or
a login dialog if using :term:`HTTP` or
cookie authentication mode.

.. _debian-setup:

Setup script on Debian, Ubuntu and derivatives
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Debian and Ubuntu have changed the way in which the setup script is enabled and disabled, in a way
that single command has to be executed for either of these.

To allow editing configuration invoke:

.. code-block:: sh
/usr/sbin/pma-configure
To block editing configuration invoke:

.. code-block:: sh
/usr/sbin/pma-secure
Setup script on openSUSE
~~~~~~~~~~~~~~~~~~~~~~~~

Some openSUSE releases do not include setup script in the package. In case you
want to generate configuration on these you can either download original
package from <https://www.phpmyadmin.net/> or use setup script on our demo
server: <https://demo.phpmyadmin.net/master/setup/>.
server: <https://demo.phpmyadmin.net/master/public/setup/>.
Copy link
Member

@williamdes williamdes Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on my long todo list, for 6.0 we should avise users to use public as the root.
As should the demo server

Suggested change
with the ``/setup`` suffix. The changes are not saved to the server, you need to
use the :guilabel:`Download` button to save them to your computer and then upload
to the server.
@@ -787,7 +787,7 @@ Setup script on openSUSE
Some openSUSE releases do not include setup script in the package. In case you
want to generate configuration on these you can either download original
package from <https://www.phpmyadmin.net/> or use setup script on our demo
server: <https://demo.phpmyadmin.net/master/setup/>.

Copy link
Member

@MauricioFauth MauricioFauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@codecov

This comment was marked as off-topic.


Next, open your browser and visit the location where you installed phpMyAdmin,
with the ``/setup`` suffix. The changes are not saved to the server, you need to
with the ``/public/setup`` suffix. The changes are not saved to the server, you need to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should not have public in the path, else it means the public prefix root was not well deployed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is the current behavior of both my system and the demo server, is that incorrect?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but it is a webserver configuration issue
We should make sure our users understand the public folder should be the root

is probably the best choice for shared hosting.
* Deny access to auxiliary files in :file:`./libraries/` or
:file:`./templates/` subfolders in your webserver configuration.
* Deny access to auxiliary files in :file:`libraries/` or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They did not configure the server to have public as the root
red flag

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change this section, then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep this section to list all folders to deny access for, if users are not able to some reason to set the root folder to public/

ibennetch added a commit to ibennetch/phpmyadmin that referenced this pull request Oct 28, 2025
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
@ibennetch
Copy link
Member Author

Thanks for the great feedback. I've incorporated most of your comments in e844625 which I just pushed along with some other work that's in progress.

* Remove old references
* Remove "added in" or "new in" if it's quite an old feature
* Some language improvements

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
… improve unnecessary automatic smart quotes.

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
@ibennetch ibennetch changed the title Docs Documentation improvements - remove outdated information and improve some areas Nov 21, 2025
@ibennetch
Copy link
Member Author

I think this is ready to go except I think we should decide how to handle the phpmyadmin/setup vs phpmyadmin/public/setup section from #19881 (review).

I believe what I've written here matches the current behavior, so if that's true my suggestion is to improve/fix the suggestion to remove the /public/ part in another commit.

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
…les exist

Fixes phpmyadmin#15777

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants