Fix #13951 wrong parsing partitions #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When partition names contain "_", the parser wasn't reading the full name, but stopped before the first "_". Signed-off-by: Hugues Peccatte <hugues.peccatte@aareon.fr>
williamdes
approved these changes
Nov 1, 2019
Member
|
Can you please add a test case? Btw we merge bug fixes on QA branch, so if you want to rebase :) |
Contributor
Author
|
Sorry, I created the PR on the wrong branch, but the commit were done on QA. I'll see to update the unit tests. |
Member
|
In that case, it’s quite easy to change the target branch here on GitHub (though I can’t do it right now as I’m on mobile).
Near the top of the page is an Edit button for changing the pull request title. If you cli k that, the branch name turns to a drop down selector.
Thanks for your contribution!
|
Contributor
Author
|
@williamdes @ibennetch , test case is done. Is this OK? |
Contributor
Author
|
I saw the failure in the unit test! I'll fix it and run the whole tests, not only the |
Signed-off-by: Hugues Peccatte <hugues.peccatte@aareon.fr>
Contributor
Author
|
Should be better now... |
williamdes
approved these changes
Nov 1, 2019
Member
williamdes
left a comment
williamdes
left a comment
There was a problem hiding this comment.
@Tithugues I really do appreciate your work and the test you added ! 💯
williamdes
added a commit
that referenced
this pull request
Nov 1, 2019
Fixes: phpmyadmin/phpmyadmin#13951 Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes
added a commit
that referenced
this pull request
Nov 1, 2019
Signed-off-by: William Desportes <williamdes@wdes.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When partition names starts with a number, the parser wasn't reading the full name and stopped before the first "_".