Implement subnet support for clients - #708
Merged
Merged
Conversation
…t may use Classless Inter-Domain Routing (CIDR) notation. This is also known as variable-length subnet masking (VLSM) technique. Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
…dition. Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/subnetting-doesnt-appear-to-work-for-groups/28813/25 |
DL6ER
marked this pull request as ready for review
March 24, 2020 13:06
… enabled. Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
PromoFaux
approved these changes
Mar 28, 2020
3 tasks
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/netzwerk-in-clientliste-hinzufugen/34779/2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
This PR implements subnet support for clients. Previously, only exact client / group associations have been possible, like
192.168.0.1. This PR allows for arbitrarily complex subnet configurations using the widely known Classless Inter-Domain Routing (CIDR) notation.This allows users to specify "broad clients" such as
192.168.1.0/24which will match al clients in the range192.168.1.1to192.168.1.255(256 devices),10.8.0.0/16will match all clients in the range10.8.0.1to10.8.255.255(65,536 devices),192.168.100.0/22represents the 1024 IPv4 addresses from192.168.100.0to192.168.103.255.This implementation is IPv6-aware and can be used for IPv6 subnets as well, such as the IPv6 block
2001:db8::/48representing the block of IPv6 addresses from2001:db8:0:0:0:0:0:0to2001:db8:0:ffff:ffff:ffff:ffff:ffff(1,208,925,819,614,629,174,706,176 devices).Our implementation is more generic than what is written on the linked Wikipedia article as you can use any CIDR block (not only multiples of 4).