fix(diffs): Wrap annotation content in every overflow mode - #1021
Merged
Conversation
Annotation prose did not wrap in the default scroll overflow mode. React consumers had to add `white-space: normal` to each annotation by hand, or the text overflowed the diff column. The diffs stylesheet lives in the shadow root, so slotted annotation content gets its white-space by inheritance from the shadow-DOM `[data-annotation-content]` parent. That parent normalized white-space only under `[data-overflow="wrap"]`. In scroll mode it inherited `white-space: pre` from the `pre` element, so the slotted prose did not wrap. Set `white-space: normal` on `[data-annotation-content]` in every overflow mode. Annotations hold prose, not code, so they never need `pre`. One rule fixes every render path (React, imperative, SSR) and keeps them consistent. Also remove the now-unnecessary `white-space: normal` workaround from the docs annotations demo, and add a browser regression test for the computed white-space in scroll mode.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotation prose did not wrap in the default scroll overflow mode. React consumers had to add
white-space: normalto each annotation by hand, or the text overflowed the diff column.The diffs stylesheet lives in the shadow root, so slotted annotation content gets its white-space by inheritance from the shadow-DOM
[data-annotation-content]parent. That parent normalized white-space only under[data-overflow="wrap"]. In scroll mode it inheritedwhite-space: prefrom thepreelement, so the slotted prose did not wrap.Set
white-space: normalon[data-annotation-content]in every overflow mode. Annotations hold prose, not code, so they never needpre. One rule fixes every render path (React, imperative, SSR) and keeps them consistent.Also remove the now-unnecessary
white-space: normalworkaround from the docs annotations demo, and add a browser regression test for the computed white-space in scroll mode.