Allow annotations to be selected along with their line#155
Merged
amadeus merged 1 commit intofat/selectionfrom Nov 13, 2025
Merged
Allow annotations to be selected along with their line#155amadeus merged 1 commit intofat/selectionfrom
amadeus merged 1 commit intofat/selectionfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
amadeus
added a commit
that referenced
this pull request
Nov 13, 2025
* line selec * add example * okay cool * split * okay great * side by side selection working * rmeove a bunch of bullshit * calc annotaiton on mouse up * fix line selection logic * prgo * closer and warmer * sre * okay * mostly working * continue the blue selection down the page * jesus fuck * update the css vars * 432.5 * wesom * fix not null isus * use buttons * Another pass at selection colors (#148) * New blue, more cyan than indigo * mdo: wip * wowzers * Edit content, new design * Remove commented out blocks * Line Selection Improvements (#142) * First pass at improved handling for selection related code * Unify composedPath generation * Adding `data-alt-line` property to context lines This will make it much easier to mux selection types between unified and split diffs * Reworked LineSelectionManager This commit accomplished quite a lote * Simplified and improved SelectedLineRange API * Much simpler interface with a more human API (similar in spirit to LineAnnotations) * Selected lines fully transition between 'split' and 'unified' diffs * DOM updates from mouse events are now debounced through requestAnimationFrame * Rendering is now smarter to not actually perform dom node changes if not necessary * Improved some O(n) when it comes to processing/updating lines * Update docs to fit new types * Allow annotations to be selected along with their line (#155) * Tweak documentation for `selectedLines` in react components (#156) * Tweak documentation for `selectedLines` in react components * hopefully make it clearer * More docs content updates * consistency --------- Co-authored-by: Mark Otto <markdotto@gmail.com> Co-authored-by: Amadeus Demarzi <amadeus@users.noreply.github.com>
SlexAxton
added a commit
that referenced
this pull request
Apr 21, 2026
Improves the packages/trees file-tree profiler startup path for large pre-expanded/open trees. The change stack removes redundant prepared-input validation, represents profiler workloads with initialExpansion: 'open', slims PathStore node/storage shapes, reduces cold startup writes, tunes visible-child chunk summaries, and removes redundant FileTreeView mount/render work. Experiments: kept runs #1, #16, #18, #24, #25, #26, #28, #36, #41, #42, #43, #44, #51, #65, #67, #68, #71, #74, #80, #82, #137, #139, #140, #142, #143, #147, #149, #153, #155, #163, #165, #171, #180, #182, #186, #196 Metric: visibleRowsReadyMs 334.8ms -> 253.8ms best (-24.2%); final kept sample 267.8ms (-20.0%).
SlexAxton
added a commit
that referenced
this pull request
Apr 22, 2026
Improves the packages/trees file-tree profiler startup path for large pre-expanded/open trees. The change stack removes redundant prepared-input validation, represents profiler workloads with initialExpansion: 'open', slims PathStore node/storage shapes, reduces cold startup writes, tunes visible-child chunk summaries, and removes redundant FileTreeView mount/render work. Experiments: kept runs #1, #16, #18, #24, #25, #26, #28, #36, #41, #42, #43, #44, #51, #65, #67, #68, #71, #74, #80, #82, #137, #139, #140, #142, #143, #147, #149, #153, #155, #163, #165, #171, #180, #182, #186, #196 Metric: visibleRowsReadyMs 334.8ms -> 253.8ms best (-24.2%); final kept sample 267.8ms (-20.0%).
SlexAxton
added a commit
that referenced
this pull request
Apr 22, 2026
) Optimize file-tree startup for large open trees Improves the packages/trees file-tree profiler startup path for large pre-expanded/open trees. The change stack removes redundant prepared-input validation, represents profiler workloads with initialExpansion: 'open', slims PathStore node/storage shapes, reduces cold startup writes, tunes visible-child chunk summaries, and removes redundant FileTreeView mount/render work. Experiments: kept runs #1, #16, #18, #24, #25, #26, #28, #36, #41, #42, #43, #44, #51, #65, #67, #68, #71, #74, #80, #82, #137, #139, #140, #142, #143, #147, #149, #153, #155, #163, #165, #171, #180, #182, #186, #196 Metric: visibleRowsReadyMs 334.8ms -> 253.8ms best (-24.2%); final kept sample 267.8ms (-20.0%).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes some of the tricky hacks required to fake an annotation being attached to its selected line. Now any annotation following a selected line will also become selected.