Skip to content

Create DiffHeaderRenderer Class#41

Merged
amadeus merged 9 commits intomainfrom
amadeus/diff-features
Oct 12, 2025
Merged

Create DiffHeaderRenderer Class#41
amadeus merged 9 commits intomainfrom
amadeus/diff-features

Conversation

@amadeus
Copy link
Copy Markdown
Member

@amadeus amadeus commented Oct 12, 2025

This PR adds a few important pieces that I've been neglecting

  • Header component can now inherit from the shiki theme
  • Added a foundational svg sprite sheet and implemented the change type icons into the header
  • Refactored theme to theme-mode for overriding system theme to help reduce general confusion of shiki themes vs dark/light mode
  • Fixed a bunch of bugs around changing theme and languages after an instance has been created
    • Removes the need for a key in the FileDiff demo stuff
  • Fixed some shiki dep stuff

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
pierrejs-diff-demo Ready Ready Preview Oct 12, 2025 9:15pm
pierrejs-docs Ready Ready Preview Oct 12, 2025 9:15pm

* Fixed the issue with document being unavailable on the server
* Fixed some css property type issues
Lot of random type errors and lint errors and stuff
@amadeus amadeus force-pushed the amadeus/diff-features branch from a7ac8b4 to 96ad6fc Compare October 12, 2025 21:14
@amadeus amadeus merged commit 8434338 into main Oct 12, 2025
2 checks passed
@amadeus amadeus deleted the amadeus/diff-features branch October 12, 2025 21:16
SlexAxton added a commit that referenced this pull request Apr 21, 2026
Improves the packages/trees file-tree profiler startup path for large pre-expanded/open trees. The change stack removes redundant prepared-input validation, represents profiler workloads with initialExpansion: 'open', slims PathStore node/storage shapes, reduces cold startup writes, tunes visible-child chunk summaries, and removes redundant FileTreeView mount/render work.

Experiments: kept runs #1, #16, #18, #24, #25, #26, #28, #36, #41, #42, #43, #44, #51, #65, #67, #68, #71, #74, #80, #82, #137, #139, #140, #142, #143, #147, #149, #153, #155, #163, #165, #171, #180, #182, #186, #196
Metric: visibleRowsReadyMs 334.8ms -> 253.8ms best (-24.2%); final kept sample 267.8ms (-20.0%).
SlexAxton added a commit that referenced this pull request Apr 22, 2026
Improves the packages/trees file-tree profiler startup path for large pre-expanded/open trees. The change stack removes redundant prepared-input validation, represents profiler workloads with initialExpansion: 'open', slims PathStore node/storage shapes, reduces cold startup writes, tunes visible-child chunk summaries, and removes redundant FileTreeView mount/render work.

Experiments: kept runs #1, #16, #18, #24, #25, #26, #28, #36, #41, #42, #43, #44, #51, #65, #67, #68, #71, #74, #80, #82, #137, #139, #140, #142, #143, #147, #149, #153, #155, #163, #165, #171, #180, #182, #186, #196
Metric: visibleRowsReadyMs 334.8ms -> 253.8ms best (-24.2%); final kept sample 267.8ms (-20.0%).
SlexAxton added a commit that referenced this pull request Apr 22, 2026
)

Optimize file-tree startup for large open trees

Improves the packages/trees file-tree profiler startup path for large pre-expanded/open trees. The change stack removes redundant prepared-input validation, represents profiler workloads with initialExpansion: 'open', slims PathStore node/storage shapes, reduces cold startup writes, tunes visible-child chunk summaries, and removes redundant FileTreeView mount/render work.

Experiments: kept runs #1, #16, #18, #24, #25, #26, #28, #36, #41, #42, #43, #44, #51, #65, #67, #68, #71, #74, #80, #82, #137, #139, #140, #142, #143, #147, #149, #153, #155, #163, #165, #171, #180, #182, #186, #196
Metric: visibleRowsReadyMs 334.8ms -> 253.8ms best (-24.2%); final kept sample 267.8ms (-20.0%).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant