fix(diffs): empty files marked as deleted - #599
Merged
amadeus merged 1 commit intoApr 29, 2026
Conversation
|
@AnatoleLucet is attempting to deploy a commit to the Pierre Computer Company Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
amadeus
approved these changes
Apr 29, 2026
amadeus
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix! I probably will want to strengthen this a bit more in the future even (by using undefined-ness to make this more explicit, but for now I think this is a good change!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hello 👋
I noticed a minor inconsistency while using newFile/oldFile between 1) rendering a diff of a file with content that didn't change, and 2) rendering a diff of an empty file that didn't change.
Motivation & Context
Current behavior:
File with content and no change
Empty file with no change
We should expect both diff to be of type
change, but the second one is rendered asdeleted(even though the file has not been deleted, it's just empty).New behavior:
File with content and no change
Empty file with no change
Now the empty file is correctly rendered as
changeand notdeleted.Type of changes
Checklist
contributing guidelines
bun run lint)bun run format)bun run diffs:test)How was AI used in generating this PR
No AI used at all. I just crawled trough the codebase like a caveman.
Related issues
#399-ish