Streaming Tests#640
Merged
amadeus merged 7 commits intoMay 6, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f094e95129
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
amadeus
force-pushed
the
amadeus/streaming-tests
branch
from
f094e95 to
4712a8b
Compare
amadeus
force-pushed
the
amadeus/streaming-tests
branch
from
4712a8b to
827127b
Compare
amadeus
force-pushed
the
amadeus/streaming-tests
branch
from
827127b to
04cd7a6
Compare
This at least organizes/hides some of the craziness
…React Much better performance, a lot less fuckery
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a84dd4846
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
amadeus
force-pushed
the
amadeus/streaming-tests
branch
from
d310bd2 to
1a8dcd1
Compare
amadeus
added a commit
that referenced
this pull request
May 7, 2026
* Better support flattened changes * Refactor API to use .diff (but maintain .patch compat) * Add diff stats * Rework fetching into an improve system * Rename GHViewer to ReviewUI * Fix diffIndicators triggering UI updates on change in CodeView That's what i get for not testing all my features, :kek: * Added a new proper export type for DiffIndicators * Updated areas in the codebase that used the inline stuff * Refactored virtualization logic a bit for setOptions and how it it can manage updates * Hopefully more future proof and cleaner code to reason about * Add support for setting diffIndicators in diffshub * tweak styles for folders * Improve error and fetching states * Revamp stats and monitor * new home faq for examples * Smol mb tweak to diff stats? * Streaming Tests (#640) * Improve React/VanillaJS APIs for streaming scenarios * First version of streaming diff system... it's really sorta slopped in terms of how code is organized and used, a lot of inline shit and a lot to wrap my head around. The real fix would be a sort of class based imperative system for managing state, that can expose apis and stuff for more performant mutations. * Refactor streaming system into usePatchLoader This at least organizes/hides some of the craziness * Implement new imperative APIs for CodeView, and make it an option in React Much better performance, a lot less fuckery * Remove old max line check (it no longer matters) * PR feedback that wasn't real, despite AI really wanted to `well actually` me * Update docs for new imperative APIs for CodeView * Add support for githubusercontent.com * improve url examples * Rewrite url to more reflect new API * Fix potential bug with trailing slashes * Fix WorkerPool rendering race condition Don't allow the diffs to render if the worker pool is not initialized * Fix staggered loading * Fix loading state bug with new workerPool status * Harden managing worker pool state --------- Co-authored-by: Mark Otto <markdotto@gmail.com>
mdo
pushed a commit
that referenced
this pull request
May 7, 2026
* Improve React/VanillaJS APIs for streaming scenarios * First version of streaming diff system... it's really sorta slopped in terms of how code is organized and used, a lot of inline shit and a lot to wrap my head around. The real fix would be a sort of class based imperative system for managing state, that can expose apis and stuff for more performant mutations. * Refactor streaming system into usePatchLoader This at least organizes/hides some of the craziness * Implement new imperative APIs for CodeView, and make it an option in React Much better performance, a lot less fuckery * Remove old max line check (it no longer matters) * PR feedback that wasn't real, despite AI really wanted to `well actually` me * Update docs for new imperative APIs for CodeView
amadeus
added a commit
that referenced
this pull request
May 7, 2026
* Better support flattened changes * Refactor API to use .diff (but maintain .patch compat) * Add diff stats * Rework fetching into an improve system * Rename GHViewer to ReviewUI * Fix diffIndicators triggering UI updates on change in CodeView That's what i get for not testing all my features, :kek: * Added a new proper export type for DiffIndicators * Updated areas in the codebase that used the inline stuff * Refactored virtualization logic a bit for setOptions and how it it can manage updates * Hopefully more future proof and cleaner code to reason about * Add support for setting diffIndicators in diffshub * tweak styles for folders * Improve error and fetching states * Revamp stats and monitor * new home faq for examples * Smol mb tweak to diff stats? * Streaming Tests (#640) * Improve React/VanillaJS APIs for streaming scenarios * First version of streaming diff system... it's really sorta slopped in terms of how code is organized and used, a lot of inline shit and a lot to wrap my head around. The real fix would be a sort of class based imperative system for managing state, that can expose apis and stuff for more performant mutations. * Refactor streaming system into usePatchLoader This at least organizes/hides some of the craziness * Implement new imperative APIs for CodeView, and make it an option in React Much better performance, a lot less fuckery * Remove old max line check (it no longer matters) * PR feedback that wasn't real, despite AI really wanted to `well actually` me * Update docs for new imperative APIs for CodeView * Add support for githubusercontent.com * improve url examples * Rewrite url to more reflect new API * Fix potential bug with trailing slashes * Fix WorkerPool rendering race condition Don't allow the diffs to render if the worker pool is not initialized * Fix staggered loading * Fix loading state bug with new workerPool status * Harden managing worker pool state --------- Co-authored-by: Mark Otto <markdotto@gmail.com>
amadeus
added a commit
that referenced
this pull request
May 8, 2026
* Better support flattened changes * Refactor API to use .diff (but maintain .patch compat) * Add diff stats * Rework fetching into an improve system * Rename GHViewer to ReviewUI * Fix diffIndicators triggering UI updates on change in CodeView That's what i get for not testing all my features, :kek: * Added a new proper export type for DiffIndicators * Updated areas in the codebase that used the inline stuff * Refactored virtualization logic a bit for setOptions and how it it can manage updates * Hopefully more future proof and cleaner code to reason about * Add support for setting diffIndicators in diffshub * tweak styles for folders * Improve error and fetching states * Revamp stats and monitor * new home faq for examples * Smol mb tweak to diff stats? * Streaming Tests (#640) * Improve React/VanillaJS APIs for streaming scenarios * First version of streaming diff system... it's really sorta slopped in terms of how code is organized and used, a lot of inline shit and a lot to wrap my head around. The real fix would be a sort of class based imperative system for managing state, that can expose apis and stuff for more performant mutations. * Refactor streaming system into usePatchLoader This at least organizes/hides some of the craziness * Implement new imperative APIs for CodeView, and make it an option in React Much better performance, a lot less fuckery * Remove old max line check (it no longer matters) * PR feedback that wasn't real, despite AI really wanted to `well actually` me * Update docs for new imperative APIs for CodeView * Add support for githubusercontent.com * improve url examples * Rewrite url to more reflect new API * Fix potential bug with trailing slashes * Fix WorkerPool rendering race condition Don't allow the diffs to render if the worker pool is not initialized * Fix staggered loading * Fix loading state bug with new workerPool status * Harden managing worker pool state --------- Co-authored-by: Mark Otto <markdotto@gmail.com>
amadeus
added a commit
that referenced
this pull request
May 8, 2026
* Better support flattened changes * Refactor API to use .diff (but maintain .patch compat) * Add diff stats * Rework fetching into an improve system * Rename GHViewer to ReviewUI * Fix diffIndicators triggering UI updates on change in CodeView That's what i get for not testing all my features, :kek: * Added a new proper export type for DiffIndicators * Updated areas in the codebase that used the inline stuff * Refactored virtualization logic a bit for setOptions and how it it can manage updates * Hopefully more future proof and cleaner code to reason about * Add support for setting diffIndicators in diffshub * tweak styles for folders * Improve error and fetching states * Revamp stats and monitor * new home faq for examples * Smol mb tweak to diff stats? * Streaming Tests (#640) * Improve React/VanillaJS APIs for streaming scenarios * First version of streaming diff system... it's really sorta slopped in terms of how code is organized and used, a lot of inline shit and a lot to wrap my head around. The real fix would be a sort of class based imperative system for managing state, that can expose apis and stuff for more performant mutations. * Refactor streaming system into usePatchLoader This at least organizes/hides some of the craziness * Implement new imperative APIs for CodeView, and make it an option in React Much better performance, a lot less fuckery * Remove old max line check (it no longer matters) * PR feedback that wasn't real, despite AI really wanted to `well actually` me * Update docs for new imperative APIs for CodeView * Add support for githubusercontent.com * improve url examples * Rewrite url to more reflect new API * Fix potential bug with trailing slashes * Fix WorkerPool rendering race condition Don't allow the diffs to render if the worker pool is not initialized * Fix staggered loading * Fix loading state bug with new workerPool status * Harden managing worker pool state --------- Co-authored-by: Mark Otto <markdotto@gmail.com>
amadeus
added a commit
that referenced
this pull request
May 9, 2026
* Better support flattened changes * Refactor API to use .diff (but maintain .patch compat) * Add diff stats * Rework fetching into an improve system * Rename GHViewer to ReviewUI * Fix diffIndicators triggering UI updates on change in CodeView That's what i get for not testing all my features, :kek: * Added a new proper export type for DiffIndicators * Updated areas in the codebase that used the inline stuff * Refactored virtualization logic a bit for setOptions and how it it can manage updates * Hopefully more future proof and cleaner code to reason about * Add support for setting diffIndicators in diffshub * tweak styles for folders * Improve error and fetching states * Revamp stats and monitor * new home faq for examples * Smol mb tweak to diff stats? * Streaming Tests (#640) * Improve React/VanillaJS APIs for streaming scenarios * First version of streaming diff system... it's really sorta slopped in terms of how code is organized and used, a lot of inline shit and a lot to wrap my head around. The real fix would be a sort of class based imperative system for managing state, that can expose apis and stuff for more performant mutations. * Refactor streaming system into usePatchLoader This at least organizes/hides some of the craziness * Implement new imperative APIs for CodeView, and make it an option in React Much better performance, a lot less fuckery * Remove old max line check (it no longer matters) * PR feedback that wasn't real, despite AI really wanted to `well actually` me * Update docs for new imperative APIs for CodeView * Add support for githubusercontent.com * improve url examples * Rewrite url to more reflect new API * Fix potential bug with trailing slashes * Fix WorkerPool rendering race condition Don't allow the diffs to render if the worker pool is not initialized * Fix staggered loading * Fix loading state bug with new workerPool status * Harden managing worker pool state --------- Co-authored-by: Mark Otto <markdotto@gmail.com>
amadeus
added a commit
that referenced
this pull request
May 9, 2026
* Better support flattened changes * Refactor API to use .diff (but maintain .patch compat) * Add diff stats * Rework fetching into an improve system * Rename GHViewer to ReviewUI * Fix diffIndicators triggering UI updates on change in CodeView That's what i get for not testing all my features, :kek: * Added a new proper export type for DiffIndicators * Updated areas in the codebase that used the inline stuff * Refactored virtualization logic a bit for setOptions and how it it can manage updates * Hopefully more future proof and cleaner code to reason about * Add support for setting diffIndicators in diffshub * tweak styles for folders * Improve error and fetching states * Revamp stats and monitor * new home faq for examples * Smol mb tweak to diff stats? * Streaming Tests (#640) * Improve React/VanillaJS APIs for streaming scenarios * First version of streaming diff system... it's really sorta slopped in terms of how code is organized and used, a lot of inline shit and a lot to wrap my head around. The real fix would be a sort of class based imperative system for managing state, that can expose apis and stuff for more performant mutations. * Refactor streaming system into usePatchLoader This at least organizes/hides some of the craziness * Implement new imperative APIs for CodeView, and make it an option in React Much better performance, a lot less fuckery * Remove old max line check (it no longer matters) * PR feedback that wasn't real, despite AI really wanted to `well actually` me * Update docs for new imperative APIs for CodeView * Add support for githubusercontent.com * improve url examples * Rewrite url to more reflect new API * Fix potential bug with trailing slashes * Fix WorkerPool rendering race condition Don't allow the diffs to render if the worker pool is not initialized * Fix staggered loading * Fix loading state bug with new workerPool status * Harden managing worker pool state --------- Co-authored-by: Mark Otto <markdotto@gmail.com>
amadeus
added a commit
that referenced
this pull request
May 9, 2026
* Better support flattened changes * Refactor API to use .diff (but maintain .patch compat) * Add diff stats * Rework fetching into an improve system * Rename GHViewer to ReviewUI * Fix diffIndicators triggering UI updates on change in CodeView That's what i get for not testing all my features, :kek: * Added a new proper export type for DiffIndicators * Updated areas in the codebase that used the inline stuff * Refactored virtualization logic a bit for setOptions and how it it can manage updates * Hopefully more future proof and cleaner code to reason about * Add support for setting diffIndicators in diffshub * tweak styles for folders * Improve error and fetching states * Revamp stats and monitor * new home faq for examples * Smol mb tweak to diff stats? * Streaming Tests (#640) * Improve React/VanillaJS APIs for streaming scenarios * First version of streaming diff system... it's really sorta slopped in terms of how code is organized and used, a lot of inline shit and a lot to wrap my head around. The real fix would be a sort of class based imperative system for managing state, that can expose apis and stuff for more performant mutations. * Refactor streaming system into usePatchLoader This at least organizes/hides some of the craziness * Implement new imperative APIs for CodeView, and make it an option in React Much better performance, a lot less fuckery * Remove old max line check (it no longer matters) * PR feedback that wasn't real, despite AI really wanted to `well actually` me * Update docs for new imperative APIs for CodeView * Add support for githubusercontent.com * improve url examples * Rewrite url to more reflect new API * Fix potential bug with trailing slashes * Fix WorkerPool rendering race condition Don't allow the diffs to render if the worker pool is not initialized * Fix staggered loading * Fix loading state bug with new workerPool status * Harden managing worker pool state --------- Co-authored-by: Mark Otto <markdotto@gmail.com>
amadeus
added a commit
that referenced
this pull request
May 12, 2026
* Better support flattened changes * Refactor API to use .diff (but maintain .patch compat) * Add diff stats * Rework fetching into an improve system * Rename GHViewer to ReviewUI * Fix diffIndicators triggering UI updates on change in CodeView That's what i get for not testing all my features, :kek: * Added a new proper export type for DiffIndicators * Updated areas in the codebase that used the inline stuff * Refactored virtualization logic a bit for setOptions and how it it can manage updates * Hopefully more future proof and cleaner code to reason about * Add support for setting diffIndicators in diffshub * tweak styles for folders * Improve error and fetching states * Revamp stats and monitor * new home faq for examples * Smol mb tweak to diff stats? * Streaming Tests (#640) * Improve React/VanillaJS APIs for streaming scenarios * First version of streaming diff system... it's really sorta slopped in terms of how code is organized and used, a lot of inline shit and a lot to wrap my head around. The real fix would be a sort of class based imperative system for managing state, that can expose apis and stuff for more performant mutations. * Refactor streaming system into usePatchLoader This at least organizes/hides some of the craziness * Implement new imperative APIs for CodeView, and make it an option in React Much better performance, a lot less fuckery * Remove old max line check (it no longer matters) * PR feedback that wasn't real, despite AI really wanted to `well actually` me * Update docs for new imperative APIs for CodeView * Add support for githubusercontent.com * improve url examples * Rewrite url to more reflect new API * Fix potential bug with trailing slashes * Fix WorkerPool rendering race condition Don't allow the diffs to render if the worker pool is not initialized * Fix staggered loading * Fix loading state bug with new workerPool status * Harden managing worker pool state --------- Co-authored-by: Mark Otto <markdotto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing out streaming data...