Skip to content

Conversation

@sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 2, 2020

cherry-pick #2587 to release-3.1


Signed-off-by: disksing i@disksing.com

What is changed, added or deleted? (Required)

add placement rules configuratoin guide

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version, including v4.0 changes for now)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

original PR #2246

  • This PR is translated from:
  • Other reference link(s):

* how-to: add placement rule document

Signed-off-by: disksing <i@disksing.com>

* minor update

Signed-off-by: disksing <i@disksing.com>

* Update how-to/configure/placement-rules.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update how-to/configure/placement-rules.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update how-to/configure/placement-rules.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update how-to/configure/placement-rules.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update how-to/configure/placement-rules.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update how-to/configure/placement-rules.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update how-to/configure/placement-rules.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update how-to/configure/placement-rules.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* address comment

Signed-off-by: disksing <i@disksing.com>

* Update how-to/configure/placement-rules.md

Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>

* Update placement-rules.md

* Update placement-rules.md

* refine format and language

* fix a typo

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: Ian <ArGregoryIan@gmail.com>
Co-authored-by: TomShawn <1135243111@qq.com>
@sre-bot sre-bot mentioned this pull request Apr 2, 2020
4 tasks
@sre-bot sre-bot added type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR. v4.0 This PR/issue applies to TiDB v4.0. labels Apr 2, 2020
@sre-bot sre-bot requested review from IANTHEREAL and TomShawn April 2, 2020 09:56
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn merged commit 154122b into pingcap:release-3.1 Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR. v4.0 This PR/issue applies to TiDB v4.0.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants