Skip to content

Conversation

@lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Apr 15, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@lidezhu lidezhu linked an issue Apr 15, 2020 that may be closed by this pull request
@lidezhu lidezhu requested a review from toutdesuite April 16, 2020 03:38
Copy link
Contributor

@toutdesuite toutdesuite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toutdesuite toutdesuite changed the title Add more explanation for tiflash multi disk deployment tiflash: add more explanation for multi disk deployment Apr 16, 2020
@toutdesuite toutdesuite added the translation/doing This PR’s assignee is translating this PR. label Apr 16, 2020
@yikeke yikeke added the status/require-change Needs the author to address comments. label Apr 17, 2020
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
@yikeke yikeke added status/PTAL This PR is ready for reviewing. and removed status/require-change Needs the author to address comments. labels Apr 18, 2020
@yikeke yikeke requested a review from marsishandsome April 18, 2020 13:16
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented Apr 20, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2020

/run-all-tests

@sre-bot sre-bot merged commit d574839 into pingcap:master Apr 20, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Apr 20, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2020

cherry pick to release-3.1 in PR #2833

@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2020

cherry pick to release-4.0 in PR #2834

@toutdesuite toutdesuite added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 7, 2020
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

建议对 支持多目录存储 增加超链接

5 participants