Skip to content

Conversation

@sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 6, 2020

cherry-pick #2467 to release-3.1


What is changed, added or deleted? (Required)

add more explanation for multi disk deployment

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot added status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR. labels May 6, 2020
@sre-bot sre-bot requested review from lidezhu and yikeke May 6, 2020 15:18
@yikeke
Copy link
Contributor

yikeke commented May 6, 2020

Please align the changes in pingcap/docs-cn#2833. @toutdesuite

@yikeke yikeke added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels May 8, 2020
@toutdesuite
Copy link
Contributor

@yikeke PTAL. Thanks

@sre-bot
Copy link
Contributor Author

sre-bot commented May 8, 2020

@yikeke, @lidezhu, PTAL.

1 similar comment
@sre-bot
Copy link
Contributor Author

sre-bot commented May 8, 2020

@yikeke, @lidezhu, PTAL.

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented May 9, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 9, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 9, 2020

/run-all-tests

@sre-bot sre-bot merged commit 2195b34 into pingcap:release-3.1 May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/require-change Needs the author to address comments. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants