Skip to content

Conversation

@toutdesuite
Copy link
Contributor

@toutdesuite toutdesuite commented May 6, 2020

What is changed, added or deleted? (Required)

add more explanation for multi disk deployment

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@toutdesuite toutdesuite requested review from lidezhu and yikeke May 6, 2020 10:59
@toutdesuite toutdesuite added needs-cherry-pick-3.1 status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels May 6, 2020
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Copy link
Contributor

@lidezhu lidezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

toutdesuite and others added 3 commits May 6, 2020 20:55
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented May 6, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 6, 2020

/run-all-tests

@sre-bot sre-bot merged commit 58b3210 into pingcap:master May 6, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request May 6, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented May 6, 2020

cherry pick to release-3.1 in PR #2471

@sre-bot
Copy link
Contributor

sre-bot commented May 6, 2020

cherry pick to release-4.0 in PR #2473

yikeke pushed a commit that referenced this pull request May 6, 2020
Co-authored-by: toutdesuite <guizhiluo2014@163.com>
sre-bot added a commit that referenced this pull request May 9, 2020
@toutdesuite toutdesuite deleted the multi-disk-deployment branch May 11, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants