TiUP: fix grammar and format for topology.example.yaml #2846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toutdesuite
added
needs-cherry-pick-4.0
translation/done
toutdesuite
changed the title
added 2 commits
April 21, 2020 17:19
Contributor
|
Please also update the file template in quick start guide doc. @toutdesuite |
5 tasks
Contributor
Author
|
@yikeke The file is updated. PTAL |
yikeke
reviewed
Apr 21, 2020
how-to/deploy/orchestrated/tiup.md
Outdated
| log_dir: "deploy/tidb-4000/log" | ||
| numa_node: "0,1" | ||
| # Config is used to overwrite the `server_configs.tidb` values | ||
| # The following configs are used to overwrite the `server_configs.pd` values. |
Contributor
There was a problem hiding this comment.
Suggested change
| # The following configs are used to overwrite the `server_configs.pd` values. | |
| # The following configs are used to overwrite the `server_configs.tidb` values. |
yikeke
reviewed
Apr 21, 2020
5 tasks
Contributor
|
/merge |
sre-bot
added
the
status/can-merge
Contributor
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/docs-cn
that referenced
this pull request
Apr 21, 2020
5 tasks
Contributor
|
cherry pick to release-4.0 in PR #2850 |
5 tasks
yikeke
pushed a commit
that referenced
this pull request
Apr 21, 2020
rleungx
pushed a commit
to rleungx/docs-cn
that referenced
this pull request
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?