tiup: fix some details in tiup deployment doc #2291
Conversation
yikeke
added
needs-cherry-pick-4.0
translation/from-docs-cn
yikeke
left a comment
yikeke
left a comment
There was a problem hiding this comment.
Waiting on @superlzs0476 's reply to https://github.com/pingcap/docs-cn/pull/2705/files#r410694225
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
|
|
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
| deploy_dir: "/tidb-deploy" | ||
| data_dir: "/tidb-data" | ||
| # # Monitored variables are used to all the machine |
There was a problem hiding this comment.
| # # Monitored variables are used to all the machine | |
| # # Monitored variables are used to all the machines. |
| # deploy_dir: "/tidb-deploy/monitored-9100" | ||
| # data_dir: "/tidb-data/monitored-9100" | ||
| # log_dir: "/tidb-deploy/monitored-9100/log" | ||
| # # Server configs are used to specify the runtime configuration of TiDB components |
There was a problem hiding this comment.
| # # Server configs are used to specify the runtime configuration of TiDB components | |
| # # Server configs are used to specify the runtime configuration of TiDB components. |
| # # All configuration items use points to represent the hierarchy, e.g: | ||
| # # readpool.storage.use-unified-pool | ||
| # # ^ ^ | ||
| # # You can overwrite this configuration via instance-level `config` field |
There was a problem hiding this comment.
| # # You can overwrite this configuration via instance-level `config` field | |
| # # You can overwrite this configuration via the instance-level `config` field. |
| # data_dir: /tidb-data/tiflash-9000 | ||
| # log_dir: /tidb-deploy/tiflash-9000/log | ||
| # numa_node: "0,1" | ||
| # # Config is used to overwrite the `server_configs.tiflash` values |
There was a problem hiding this comment.
| # # Config is used to overwrite the `server_configs.tiflash` values | |
| # # Config is used to overwrite the `server_configs.tiflash` values. |
| # - host: 10.0.1.17 | ||
| # port: 8249 | ||
| # data_dir: "/tidb-data/drainer-8249" | ||
| # # if drainer doesn't have checkpoint, use initial commitTS to initial checkpoint |
There was a problem hiding this comment.
| # # if drainer doesn't have checkpoint, use initial commitTS to initial checkpoint | |
| # # If drainer doesn't have any checkpoint, using initial commitTS to initialize the checkpoint |
| # port: 8249 | ||
| # data_dir: "/tidb-data/drainer-8249" | ||
| # # if drainer doesn't have checkpoint, use initial commitTS to initial checkpoint | ||
| # # will get a latest timestamp from pd if setting to be -1 (default -1) |
There was a problem hiding this comment.
| # # will get a latest timestamp from pd if setting to be -1 (default -1) | |
| # # will get a latest timestamp from pd if `commit_ts` is set to -1 (default -1). |
| # deploy_dir: "/tidb-deploy/drainer-8249" | ||
| # log_dir: "/tidb-deploy/drainer-8249/log" | ||
| # numa_node: "0,1" | ||
| # # Config is used to overwrite the `server_configs.drainer` values |
There was a problem hiding this comment.
| # # Config is used to overwrite the `server_configs.drainer` values | |
| # # Config is used to overwrite the `server_configs.drainer` values. |
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
|
For those code comment issues, I will ask @lonng to refine the configuration file template and then open another PR to fix the issues in this document. FYI. @lilin90 @superlzs0476 |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-4.0 in PR #2333 |
The template issues are fixed in Fix grammar and format for topology.example.yaml by yikeke · pingcap-incubator/tiup-cluster. I'll open another PR in docs/docs-cn to update the docs. |
docs/docs-cn updates: |
5 participants
What is changed, added or deleted? (Required)
fix some details in tiup deployment doc
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?