Skip to content

*: update using TiFlash in toc and index #3532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 8, 2020
Merged

*: update using TiFlash in toc and index #3532

merged 4 commits into from
Jun 8, 2020

Conversation

@lilin90
Copy link
Member

@lilin90 lilin90 commented Jun 5, 2020

What is changed, added or deleted? (Required)

  • Add use-tiflash.md to _index.md and 参考指南
  • Add related descriptions to TiUP production deployment doc
  • Update wording in _index.md: 部署集群 > 部署使用

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@lilin90 lilin90 requested review from kissmydb and zanmato1984 June 5, 2020 11:26
@lilin90 lilin90 self-assigned this Jun 5, 2020
@lilin90 lilin90 added the translation/doing This PR’s assignee is translating this PR. label Jun 5, 2020
@lilin90
Copy link
Member Author

lilin90 commented Jun 5, 2020

@zanmato1984 Since the link of deploy-tiflash.md exists in TiFlash 常见问题, deleting it causes a broken link. Please help confirm how to deal with it. Thanks!

@zanmato1984 zanmato1984 mentioned this pull request Jun 6, 2020
Merged
5 tasks
kissmydb
kissmydb approved these changes Jun 7, 2020
View reviewed changes
Copy link
Contributor

@kissmydb kissmydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot sre-bot mentioned this pull request Jun 8, 2020
Merged
5 tasks
@lilin90
Copy link
Member Author

lilin90 commented Jun 8, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 8, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2020

/run-all-tests

@sre-bot sre-bot merged commit a174895 into pingcap:master Jun 8, 2020
@lilin90 lilin90 deleted the update-use-tiflash branch June 8, 2020 05:00
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 8, 2020
@lilin90 @sre-bot
cherry pick pingcap#3532 to release-4.0
9d2782c 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 8, 2020
Merged
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2020

cherry pick to release-4.0 in PR #3554

lilin90 added a commit that referenced this pull request Jun 8, 2020
@sre-bot @lilin90
*: update using TiFlash in toc and index (#3532) (#3554)
8e17a62 
* cherry pick #3532 to release-4.0

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* Update production-deployment-using-tiup.md

Co-authored-by: Lilian Lee <lilin@pingcap.com>
@ran-huang ran-huang self-assigned this Jun 8, 2020
@ran-huang ran-huang mentioned this pull request Jun 8, 2020
Merged
5 tasks
@ran-huang
Copy link
Contributor

ran-huang commented Jun 8, 2020 •
edited
Loading

Aligned production-deployment-using-tiup.md in pingcap/docs#2730 (except the aliases because deploy-tiflash has not been deleted yet).

@sre-bot sre-bot mentioned this pull request Jun 8, 2020
Merged
5 tasks
@yikeke yikeke self-assigned this Jun 11, 2020
@yikeke yikeke added size/small Changes of a small size. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 19, 2020
@yikeke yikeke added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Jun 23, 2020
@yikeke yikeke mentioned this pull request Jun 23, 2020
Merged
5 tasks
@ti-srebot ti-srebot mentioned this pull request Jun 28, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanmato1984 zanmato1984 Awaiting requested review from zanmato1984

1 more reviewer

@kissmydb kissmydb kissmydb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lilin90 lilin90

@yikeke yikeke

@ran-huang ran-huang

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lilin90 @sre-bot @ran-huang @kissmydb @yikeke