Skip to content

Conversation

@zanmato1984
Copy link
Contributor

@zanmato1984 zanmato1984 commented Jun 6, 2020

What is changed, added or deleted? (Required)

Delete deploy tiflash doc, and spread its content to several dedicated docs.

Note: aliases for the deleted file is added in #3532.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zanmato1984 and others added 3 commits June 6, 2020 23:10
Co-authored-by: Flowyi <flowbehappy@gmail.com>
Co-authored-by: Flowyi <flowbehappy@gmail.com>
Co-authored-by: Flowyi <flowbehappy@gmail.com>
@flowbehappy flowbehappy self-requested a review June 6, 2020 15:13
@zanmato1984
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jun 6, 2020

Sorry @zanmato1984, you don't have permission to trigger auto merge event on this branch. You are not a committer for this part

@yikeke yikeke added the translation/doing This PR’s assignee is translating this PR. label Jun 7, 2020
@flowbehappy flowbehappy self-requested a review June 7, 2020 04:06
@flowbehappy
Copy link
Contributor

LGTM

@zanmato1984
Copy link
Contributor Author

@kissmydb PTAL

@lilin90 lilin90 assigned yikeke and unassigned yikeke Jun 8, 2020
Copy link
Contributor

@kissmydb kissmydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit 6c5c9d3 into master Jun 8, 2020
@lilin90 lilin90 deleted the remove-deploy-tiflash branch June 8, 2020 03:49
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2020

cherry pick to release-4.0 in PR #3551

lilin90 pushed a commit that referenced this pull request Jun 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: ruoxi <zanmato1984@gmail.com>
@ran-huang
Copy link
Contributor

Aligned hardware-and-software-requirements.md in pingcap/docs#2730

@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 11, 2020
@yikeke
Copy link
Contributor

yikeke commented Jun 11, 2020

Aligned hardware-and-software-requirements.md in pingcap/docs#2730

The rest of changes are aligned in pingcap/docs#2749

yikeke pushed a commit to yikeke/docs that referenced this pull request Jun 11, 2020
yikeke added a commit to pingcap/docs that referenced this pull request Jun 11, 2020
* Update TOC.md

* Update TOC.md

* Update TOC.md

* delete links that are NA yet

* add TiDB Dashboard toc

* add two links (from Binary Tarball)

* add two tispark links

* add 3 missing links

* remove binary

* Update TOC.md

Co-authored-by: Lilian Lee <lilin@pingcap.com>

* rename; add toc

* rename back

* delete an alias

* add missing links in TOC

* align pingcap/docs-cn#3542

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants