Skip to content

i18n(ja): annotate Japanese-only glossary headings with their English term - #23407

Merged
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-glossary-english-annotation
Aug 5, 2026
Merged

i18n(ja): annotate Japanese-only glossary headings with their English term#23407
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:i18n-ja-glossary-english-annotation

Conversation

@yahonda

@yahonda yahonda commented Aug 3, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

The glossary is indexed alphabetically (the <TabsPanel> A–Z tabs and the <a id="A"> letter sections). Both the ordering and the {#...} anchors are generated from the English source, while the translation only localizes the visible heading text. As a result, for entries whose heading was fully translated to Japanese, the Latin index letter no longer matches what the reader sees — e.g. 一時テーブル sits under T, 元の値 under O, 述語列 under P — so the A–Z index is hard to use.

This PR appends the English term in parentheses to the 29 Japanese-only headings, e.g. ### ストア(Store), matching the existing style already used by acronym entries such as データ定義言語(DDL) and ガベージコレクション(GC). The other 48 entries already carry an English token (product names, acronyms) and are left unchanged.

Anchors are unchanged, so all inbound links keep resolving.

Note for reviewers: This is a translation-convention change (not an MT-defect fix). If the approach is acceptable, the same convention would ideally apply to the other glossaries (dm/dm-glossary.md, ticdc/ticdc-glossary.md, tidb-lightning/tidb-lightning-glossary.md). Feedback on the format (日本語(English) vs English(日本語)) is welcome.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)

What is the related PR or file link(s)?

@ti-chi-bot

ti-chi-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 633cf7eb-dcd4-4b4d-a51c-5cfb37edeb27

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kissmydb for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 3, 2026
@yahonda
yahonda marked this pull request as ready for review August 3, 2026 04:58
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 3, 2026
@qiancai

qiancai commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

@yahonda, could you please resolve conflicts in this PR? Thanks.

@yahonda
yahonda force-pushed the i18n-ja-glossary-english-annotation branch from d69f4ff to 4896361 Compare August 4, 2026 00:18
@yahonda

yahonda commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Rebased.

@qiancai

qiancai commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

@yahonda, sorry to bother you again. It looks like there are new conflicts in this PR. Could you please take a look? Thanks!

@yahonda
yahonda force-pushed the i18n-ja-glossary-english-annotation branch from 4896361 to 463ef06 Compare August 4, 2026 02:57
@yahonda

yahonda commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Rebased.

… term

The glossary is indexed alphabetically (A–Z TabsPanel and letter sections),
and both the ordering and the {#anchors} are derived from the English source.
For entries whose heading was fully translated to Japanese, the Latin index
letter no longer matches the visible heading text, so readers cannot tell why,
for example, 一時テーブル sits under "T" or 元の値 under "O".

Append the English term in parentheses to the 29 Japanese-only headings, e.g.
データ定義言語(DDL). Anchors are unchanged, so all inbound links keep working.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@yahonda
yahonda force-pushed the i18n-ja-glossary-english-annotation branch from 463ef06 to 300b674 Compare August 4, 2026 06:32
@qiancai
qiancai merged commit df05cd5 into pingcap:i18n-ja-release-8.5 Aug 5, 2026
5 of 9 checks passed
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 5, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-05 12:19:33.854621228 +0000 UTC m=+2616959.890716284: ☑️ agreed by qiancai.

@yahonda
yahonda deleted the i18n-ja-glossary-english-annotation branch August 6, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants