Skip to content

perf-tuning: add document for partition pruning #3386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Jul 28, 2020
Merged

perf-tuning: add document for partition pruning #3386

merged 23 commits into from
Jul 28, 2020

Conversation

@Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Jul 22, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

  • Add document for logical plan optimization rule: partition pruning.
  • Translate the updated documentation according to Chinese file: 分区裁剪

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@Joyinqin
Copy link
Contributor Author

Joyinqin commented Jul 23, 2020

/label size/medium, translation/from-docs-cn, needs-cherry-pick-4.0

@ti-srebot ti-srebot added needs-cherry-pick-4.0 size/medium Changes of a medium size. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jul 23, 2020
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Jul 23, 2020

/cc lilin90, wshwsh12.

@ti-srebot ti-srebot requested a review from lilin90 July 23, 2020 02:56
@Joyinqin Joyinqin marked this pull request as ready for review July 23, 2020 02:57
ghost
ghost reviewed Jul 23, 2020
View reviewed changes
Joyinqin and others added 12 commits July 23, 2020 16:34
@yikeke yikeke mentioned this pull request Jul 27, 2020
Merged
9 tasks
lilin90
lilin90 reviewed Jul 27, 2020
View reviewed changes
@lilin90 lilin90 added the requires-followup This PR requires a follow-up task after being merged. label Jul 27, 2020
lilin90
lilin90 reviewed Jul 28, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 28, 2020
@lilin90
Copy link
Member

lilin90 commented Jul 28, 2020

@wshwsh12 Please have a tech review. Thanks!

@lilin90 lilin90 added the status/PTAL This PR is ready for reviewing. label Jul 28, 2020
@wshwsh12
Copy link
Contributor

wshwsh12 commented Jul 28, 2020

lgtm

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 28, 2020

@wshwsh12,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@lilin90 lilin90 added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 28, 2020
@lilin90
Copy link
Member

lilin90 commented Jul 28, 2020

lgtm

@wshwsh12 Thanks for your tech review~

@lilin90 lilin90 merged commit 8436ed6 into pingcap:master Jul 28, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 28, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#3386 to release-4.0
ff9d76b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 28, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 28, 2020

cherry pick to release-4.0 in PR #3435

lilin90 pushed a commit that referenced this pull request Jul 28, 2020
@ti-srebot @Joyinqin
cherry pick #3386 to release-4.0 (#3435)
1a3e9cb 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Jul 30, 2020

/unlabel follow-up

@ti-srebot ti-srebot removed the requires-followup This PR requires a follow-up task after being merged. label Jul 30, 2020
@Joyinqin Joyinqin mentioned this pull request Jul 30, 2020
Merged
5 tasks
@Joyinqin Joyinqin deleted the update-partition-pruning branch July 31, 2020 10:55
@ti-srebot ti-srebot mentioned this pull request Jul 31, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@lilin90 lilin90 lilin90 approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/medium Changes of a medium size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Joyinqin @lilin90 @wshwsh12 @ti-srebot