Skip to content

Conversation

@JmPotato
Copy link
Member

Signed-off-by: JmPotato ghzpotato@gmail.com

What is changed, added or deleted? (Required)

PD adds a new config field named IsolationLevel. This pr adds the English version introduction for it.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-srebot ti-srebot added the contribution This PR is from a community contributor. label Jul 30, 2020
@CLAassistant
Copy link

CLAassistant commented Jul 30, 2020

CLA assistant check
All committers have signed the CLA.

@JmPotato
Copy link
Member Author

PTAL @disksing @TomShawn

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@yikeke
Copy link
Contributor

yikeke commented Jul 30, 2020

/cc disksing, TomShawn

@ti-srebot ti-srebot requested review from TomShawn and disksing July 30, 2020 04:54
@yikeke yikeke added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Jul 30, 2020
@TomShawn TomShawn added size/large Changes of a large size. v5.0 This PR/issue applies to TiDB v5.0. labels Jul 30, 2020
@TomShawn
Copy link
Contributor

JmPotato and others added 8 commits July 30, 2020 16:08
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Copy link
Member Author

This line is not updated according to https://github.com/pingcap/docs-cn/pull/4104/files#diff-9b531db106a0ae770cbc4e9a62674be5R83-R84.

Thx for pointing out, PTAL again!

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great translation!
Rest LGTM

JmPotato and others added 2 commits July 30, 2020 17:04
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@JmPotato JmPotato requested a review from TomShawn July 30, 2020 09:06
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@disksing PTAL

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 30, 2020
@JmPotato
Copy link
Member Author

JmPotato commented Aug 4, 2020

@disksing PTAL

@ti-srebot
Copy link
Contributor

@disksing,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. size/large Changes of a large size. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants