metric: add more lint rules for metric panels

[D3Hunter]

What problem does this PR solve?

Issue Number: close #58435

Problem Summary:

What changed and how does it work?

see issue

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[D3Hunter]

this and below panel don't have a title, not sure what's it used for, I add a temporary title based on the expression

[D3Hunter]

it's a large change because the first row is open previously

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5387%. Comparing base (bf7016d) to head (b168758).
Report is 6 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #58436        +/-   ##
================================================
- Coverage   73.5677%   73.5387%   -0.0290%     
================================================
  Files          1681       1681                
  Lines        463846     464294       +448     
================================================
+ Hits         341241     341436       +195     
- Misses       101784     102043       +259     
+ Partials      20821      20815         -6     

Flag	Coverage Δ
integration	43.3489% <ø> (?)
unit	72.3274% <ø> (-0.0100%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.6910% <ø> (ø)
parser	∅ <ø> (∅)
br	45.7594% <ø> (-0.0300%)	⬇️

[jackysp]

You should not modify this file directly, you should edit tidb/pkg/metrics/grafana/tidb_summary.jsonnet at master · pingcap/tidb and tidb/pkg/metrics/grafana/tidb_resource_control.jsonnet at master · pingcap/tidb

[jackysp]

ditto, and see https://github.com/pingcap/tidb/blob/master/pkg/metrics/grafana/README.md for more details.

[jackysp]

LGTM

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-12-20 08:29:31.178146002 +0000 UTC m=+1204761.266948544: ☑️ agreed by hawkingrei.
• 2024-12-20 08:57:46.27951902 +0000 UTC m=+1206456.368321548: ☑️ agreed by jackysp.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, jackysp, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [hawkingrei,jackysp,wjhuang2016]
• pkg/meta/OWNERS [wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[D3Hunter]

/retest

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.