metrics: fix typo in tidb_summary.jsonnet template variable#65582
metrics: fix typo in tidb_summary.jsonnet template variable#65582ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
Conversation
|
Hi @boltandrke. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @boltandrke! |
|
Hi @boltandrke. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fix incorrect variable reference `$kuberentes` -> `$k8s_cluster` in the tidb_cluster template query. The variable was misspelled and should reference `$k8s_cluster` which is defined earlier in the dashboard templates. Signed-off-by: andrke <andrke@users.noreply.github.com>
4490b3a to
f8a4f29
Compare
|
From the description:
The link goes to a pull request, not an issue. Could you update this. Feel free to create a new issue if needed. This makes it easier to triage and cherry pick to the right branches. Also, please sign the CLA on https://cla.pingcap.net/pingcap/tidb?pullRequest=65582 |
|
/ok-to-test |
|
Introduced in cc3c905 / #32546 |
|
@just1900: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #65582 +/- ##
================================================
- Coverage 77.8520% 77.5480% -0.3041%
================================================
Files 1973 1907 -66
Lines 541968 531378 -10590
================================================
- Hits 421933 412073 -9860
- Misses 118376 119297 +921
+ Partials 1659 8 -1651
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/check-issue-triage-complete |
zimulala
left a comment
There was a problem hiding this comment.
Could you update the pd_cluster_status related content to align with the next-gen in
tidb_summary_with_keyspace_name.json and tidb_summary_with_keyspace_name.jsonnet?
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dveeden, just1900, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #65589
Problem Summary: The
tidb_clustertemplate variable query references a non-existent variable$kuberentes(typo) instead of$k8s_cluster.What changed and how does it work?
Fixed the variable reference from
$kuberentesto$k8s_clusterin:pkg/metrics/grafana/tidb_summary.jsonnet(line 62)pkg/metrics/grafana/tidb_summary.json(line 1789)The
$k8s_clustervariable is defined earlier in the dashboard templates.Check List
Tests
Side effects
Documentation
Release note