ddl: enhance checkpoint management with chunk tracking#64607
Conversation
ti-chi-bot
Bot
added
release-note-none
|
Hi @GMHDBJD. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #64607 +/- ##
================================================
+ Coverage 74.6509% 75.6398% +0.9888%
================================================
Files 1888 1890 +2
Lines 514863 523637 +8774
================================================
+ Hits 384350 396078 +11728
+ Misses 106743 103952 -2791
+ Partials 23770 23607 -163
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/retest |
|
@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
Bot
added
approved
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, joechenrh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
lgtm
and removed
needs-1-more-lgtm
| } | ||
| cp.writtenKeys += delta | ||
| cp.chunksFinished++ | ||
| if cp.chunksFinished == cp.chunksTotal { |
There was a problem hiding this comment.
It may not be correct after we support OnDuplicateKeyRemove
There was a problem hiding this comment.
OnDuplicateKeyRemove should not affect chunk count, so this is not a problem
| for { | ||
| cp := s.checkpoints[s.minTaskIDFinished] | ||
| if cp == nil || !cp.lastBatchRead || cp.writtenKeys < cp.totalKeys { | ||
| if cp == nil || !cp.lastBatchRead || cp.writtenKeys < cp.totalKeys || cp.chunksFinished < cp.chunksTotal { |
There was a problem hiding this comment.
IF !(cp.writtenKeys < cp.totalKeys), then chunksFinished must equal to chunksTotal?
So it may always be false here?
There was a problem hiding this comment.
this case handle the situation when cp.writtenKeys = cp.totalKeys, but cp.chunksFinished < cp.chunksTotal, which will be fixed in #64655
|
/retest |
|
@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
What problem does this PR solve?
Issue Number: close #64602
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.