Skip to content

ddl: still use write count for ingest worker#64655

Open
YangKeao wants to merge 2 commits into
pingcap:masterfrom
YangKeao:fix-64602
Open

ddl: still use write count for ingest worker#64655
YangKeao wants to merge 2 commits into
pingcap:masterfrom
YangKeao:fix-64602

Conversation

@YangKeao
Copy link
Copy Markdown
Member

@YangKeao YangKeao commented Nov 24, 2025

What problem does this PR solve?

Issue Number: close #64602

Problem Summary:

What changed and how does it work?

  1. Revert the counting part for index ingest worker. Let it still use the count of indexes.
  2. Remove the totalCount in tableScanWorker, because it's not used.
  3. Add ReadRowCnt in SubtaskSummary.
  4. Add a test for scanRecords to show that the count depends on how cops are handled.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2025
@YangKeao
Copy link
Copy Markdown
Member Author

/hold The row count is not as expected

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.9567%. Comparing base (3082092) to head (df9ec19).
⚠️ Report is 858 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #64655        +/-   ##
================================================
+ Coverage   74.7209%   74.9567%   +0.2358%     
================================================
  Files          1888       1889         +1     
  Lines        515161     515831       +670     
================================================
+ Hits         384933     386650      +1717     
+ Misses       106411     105430       -981     
+ Partials      23817      23751        -66     
Flag Coverage Δ
integration 48.3632% <0.0000%> (+0.2042%) ⬆️
unit 72.5564% <80.6451%> (+0.2747%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 63.1843% <ø> (+0.0030%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2025
@YangKeao
Copy link
Copy Markdown
Member Author

/retest

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao
Copy link
Copy Markdown
Member Author

/unhold

This one is fine now 😆

@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Nov 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wjhuang2016
Once this PR has been reviewed and has the lgtm label, please assign d3hunter for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 27, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Nov 27, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-27 12:48:30.001160102 +0000 UTC m=+793473.650354559: ☑️ agreed by wjhuang2016.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flaky test TestAddIndexResumesFromCheckpointAfterPartialImport

2 participants