memory: copy global mem arbitrator metrics to nextgen grafana#65042
Conversation
|
Hi @solotzg. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #65042 +/- ##
================================================
- Coverage 70.7649% 68.5919% -2.1731%
================================================
Files 1895 1873 -22
Lines 517875 509764 -8111
================================================
- Hits 366474 349657 -16817
- Misses 126884 137745 +10861
+ Partials 24517 22362 -2155
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ff4e479 to
a18228f
Compare
Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>
…able mode Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>
|
/cc @zimulala |
|
/ok-to-test |
zimulala
left a comment
There was a problem hiding this comment.
Do we need to update tidb.json too?
No, those modifications are from tidb.json. |
|
The metrics seems work both for x and dedicated, why add only for x? |
It has been implemented in tidb.json already. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yibin87, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #58194
Add more metrics about global mem-arbitrator in ng
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.