Skip to content

memory: copy global mem arbitrator metrics to nextgen grafana#65042

Merged
ti-chi-bot[bot] merged 4 commits into
pingcap:masterfrom
solotzg:wip-ng
Dec 18, 2025
Merged

memory: copy global mem arbitrator metrics to nextgen grafana#65042
ti-chi-bot[bot] merged 4 commits into
pingcap:masterfrom
solotzg:wip-ng

Conversation

@solotzg

@solotzg solotzg commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #58194

Add more metrics about global mem-arbitrator in ng

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added do-not-merge/invalid-title do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 15, 2025
@tiprow

tiprow Bot commented Dec 15, 2025

Copy link
Copy Markdown

Hi @solotzg. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@solotzg solotzg changed the title Add global memory arbitrator metrics to nextgen grafana memory: add global mem arbitrator metrics to nextgen grafana Dec 15, 2025
@codecov

codecov Bot commented Dec 15, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 16.12903% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.5919%. Comparing base (a14f0c8) to head (8580c6f).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #65042        +/-   ##
================================================
- Coverage   70.7649%   68.5919%   -2.1731%     
================================================
  Files          1895       1873        -22     
  Lines        517875     509764      -8111     
================================================
- Hits         366474     349657     -16817     
- Misses       126884     137745     +10861     
+ Partials      24517      22362      -2155     
Flag Coverage Δ
integration 41.5677% <9.6774%> (-6.6020%) ⬇️
unit 65.8688% <16.1290%> (+0.3388%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 38.4552% <ø> (-19.7524%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@solotzg
solotzg force-pushed the wip-ng branch 2 times, most recently from ff4e479 to a18228f Compare December 16, 2025 07:11
Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>
…able mode

Signed-off-by: Zhigao TONG <tongzhigao@pingcap.com>
@solotzg

solotzg commented Dec 16, 2025

Copy link
Copy Markdown
Contributor Author

/cc @zimulala

@ti-chi-bot
ti-chi-bot Bot requested a review from zimulala December 16, 2025 08:10
@zimulala

Copy link
Copy Markdown
Contributor

/ok-to-test

@ti-chi-bot ti-chi-bot Bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 17, 2025

@zimulala zimulala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update tidb.json too?

@solotzg

solotzg commented Dec 17, 2025

Copy link
Copy Markdown
Contributor Author

Do we need to update tidb.json too?

No, those modifications are from tidb.json.

@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 17, 2025
@yibin87

yibin87 commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

The metrics seems work both for x and dedicated, why add only for x?

@solotzg

solotzg commented Dec 18, 2025

Copy link
Copy Markdown
Contributor Author

The metrics seems work both for x and dedicated, why add only for x?

It has been implemented in tidb.json already.

@yibin87 yibin87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot

ti-chi-bot Bot commented Dec 18, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yibin87, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 18, 2025
@ti-chi-bot

ti-chi-bot Bot commented Dec 18, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-12-17 10:36:30.800241979 +0000 UTC m=+1642135.614019561: ☑️ agreed by zimulala.
  • 2025-12-18 01:14:18.442368411 +0000 UTC m=+1694803.256145993: ☑️ agreed by yibin87.

@solotzg solotzg changed the title memory: add global mem arbitrator metrics to nextgen grafana memory: copy global mem arbitrator metrics to nextgen grafana Dec 18, 2025
@ti-chi-bot
ti-chi-bot Bot merged commit 8de96d9 into pingcap:master Dec 18, 2025
29 checks passed
@solotzg
solotzg deleted the wip-ng branch December 18, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants