metrics: fix typo in tidb_summary.jsonnet template variable (#65582)#65613
metrics: fix typo in tidb_summary.jsonnet template variable (#65582)#65613ti-chi-bot wants to merge 1 commit intopingcap:release-7.5from
Conversation
Fix incorrect variable reference `$kuberentes` -> `$k8s_cluster` in the tidb_cluster template query. The variable was misspelled and should reference `$k8s_cluster` which is defined earlier in the dashboard templates. Signed-off-by: andrke <andrke@users.noreply.github.com>
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dveeden The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #65613 +/- ##
================================================
Coverage ? 72.2139%
================================================
Files ? 1422
Lines ? 415280
Branches ? 0
================================================
Hits ? 299890
Misses ? 95343
Partials ? 20047
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This is an automated cherry-pick of #65582
What problem does this PR solve?
Issue Number: close #65589
Problem Summary: The
tidb_clustertemplate variable query references a non-existent variable$kuberentes(typo) instead of$k8s_cluster.What changed and how does it work?
Fixed the variable reference from
$kuberentesto$k8s_clusterin:pkg/metrics/grafana/tidb_summary.jsonnet(line 62)pkg/metrics/grafana/tidb_summary.json(line 1789)The
$k8s_clustervariable is defined earlier in the dashboard templates.Check List
Tests
Side effects
Documentation
Release note