Skip to content

*: upgrade actions/setup-go@v6#67183

Merged
ti-chi-bot[bot] merged 7 commits into
pingcap:masterfrom
hawkingrei:remove_useless_dependency
Mar 27, 2026
Merged

*: upgrade actions/setup-go@v6#67183
ti-chi-bot[bot] merged 7 commits into
pingcap:masterfrom
hawkingrei:remove_useless_dependency

Conversation

@hawkingrei
Copy link
Copy Markdown
Member

@hawkingrei hawkingrei commented Mar 20, 2026

What problem does this PR solve?

Issue Number: close None

Problem Summary:

What changed and how does it work?

fix the problem that action cannot commit the BUILD.bazel.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Summary by CodeRabbit

  • Chores
    • Updated Go toolchain setup in the build workflow to use a newer version of the setup action.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. labels Mar 20, 2026
@pantheon-ai
Copy link
Copy Markdown

pantheon-ai Bot commented Mar 20, 2026

Review Complete

Findings: 0 issues
Posted: 0
Duplicates/Skipped: 0

ℹ️ Learn more details on Pantheon AI.

@ti-chi-bot ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Mar 20, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 20, 2026

📝 Walkthrough

Walkthrough

Updated the GitHub Actions composite action to use actions/setup-go@v6 instead of actions/setup-go@v4 in the TiDB build pipeline, while keeping all other configuration parameters unchanged.

Changes

Cohort / File(s) Summary
GitHub Actions Setup
.github/actions/tidb_build/action.yml
Bumped actions/setup-go version from v4 to v6 in the Go toolchain setup step.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • lance6716
  • D3Hunter
  • winoros

Poem

🐰 From v4 to v6, the Go toolchain flies,
A nimble version bump beneath the GitHub skies,
The rabbit hops with glee, no logic to debate,
Just dependencies refreshed—oh how we celebrate! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description lacks critical information: no valid issue number provided ('close None'), the connection between upgrading setup-go and fixing BUILD.bazel commits is unexplained, and the unit test checkbox is marked but no test details are provided. Provide a valid issue number or remove the placeholder, explain how the setup-go upgrade fixes the BUILD.bazel commit problem, and document the unit test that was added.
Title check ⚠️ Warning The PR title focuses on upgrading actions/setup-go@v6, but the stated objective is fixing BUILD.bazel commit failures in automated actions. Revise the title to reflect the primary objective: fixing BUILD.bazel commit failures in the workflow, e.g., 'Fix: enable automated action to commit BUILD.bazel' or similar.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 20, 2026
@hawkingrei hawkingrei force-pushed the remove_useless_dependency branch from 45a28c8 to da91fa3 Compare March 20, 2026 09:01
@ti-chi-bot ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/actions/tidb_build/action.yml (1)

21-21: Disabling repository cache may impact build performance.

Switching repository-cache from true to false will disable Bazel's repository cache. While this may help avoid issues with stale cached dependencies (potentially related to the removed asciicheck dependency), it could increase build times as external repositories will need to be fetched on each run.

If this is intentional to work around the broken dependency issue, consider re-enabling the cache once the dependency removal is fully propagated. If it's a temporary fix, a code comment explaining the rationale would help future maintainers.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/actions/tidb_build/action.yml at line 21, The change flips the Bazel
repository cache off by setting repository-cache: false which can slow builds;
either re-enable it (set repository-cache: true) if the asciicheck issue is
resolved, or keep it false but add a concise inline comment next to the
repository-cache setting explaining this is a temporary workaround for the
removed asciicheck dependency and when it should be reverted; update the
action.yml entry for repository-cache accordingly so future maintainers
understand the rationale.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/actions/tidb_build/action.yml:
- Line 21: The change flips the Bazel repository cache off by setting
repository-cache: false which can slow builds; either re-enable it (set
repository-cache: true) if the asciicheck issue is resolved, or keep it false
but add a concise inline comment next to the repository-cache setting explaining
this is a temporary workaround for the removed asciicheck dependency and when it
should be reverted; update the action.yml entry for repository-cache accordingly
so future maintainers understand the rationale.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bf740ce7-18b6-40ec-84a7-3ccdb8717c6a

📥 Commits

Reviewing files that changed from the base of the PR and between e3b29b3 and da91fa3.

📒 Files selected for processing (1)
  • .github/actions/tidb_build/action.yml

@hawkingrei hawkingrei changed the title *: remove useless dependency *: fix cannot commit the BUILD.bazel Mar 20, 2026
@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Mar 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.7832%. Comparing base (362aeba) to head (c31b772).
⚠️ Report is 46 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #67183        +/-   ##
================================================
+ Coverage   77.7710%   77.7832%   +0.0121%     
================================================
  Files          2022       1943        -79     
  Lines        554420     553698       -722     
================================================
- Hits         431178     430684       -494     
- Misses       121500     122966      +1466     
+ Partials       1742         48      -1694     
Flag Coverage Δ
integration 40.8523% <ø> (-7.2742%) ⬇️
unit 76.6718% <ø> (+0.3662%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 61.5065% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8787% <ø> (-11.9888%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

@pantheon-ai pantheon-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code looks good. No issues found.

@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 22, 2026
hawkingrei and others added 5 commits March 23, 2026 16:38
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei force-pushed the remove_useless_dependency branch from d82c9cf to 9f0ef3f Compare March 23, 2026 08:38
@ti-chi-bot ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Mar 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [lance6716,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 27, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Mar 27, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-03-22 11:39:51.109697845 +0000 UTC m=+95587.145768115: ☑️ agreed by lance6716.
  • 2026-03-27 05:20:35.242759332 +0000 UTC m=+504831.278829592: ☑️ agreed by tiancaiamao.

@hawkingrei
Copy link
Copy Markdown
Member Author

/unhold

@hawkingrei
Copy link
Copy Markdown
Member Author

/hold

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2026
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Copy Markdown
Member Author

/ok-to-test

@ti-chi-bot ti-chi-bot Bot added the ok-to-test Indicates a PR is ready to be tested. label Mar 27, 2026
@hawkingrei hawkingrei changed the title *: fix cannot commit the BUILD.bazel *: upgrade actions/setup-go@v6 Mar 27, 2026
@hawkingrei
Copy link
Copy Markdown
Member Author

/retest

@hawkingrei
Copy link
Copy Markdown
Member Author

/unhold

@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2026
@hawkingrei
Copy link
Copy Markdown
Member Author

/retest

@ti-chi-bot ti-chi-bot Bot merged commit cdad4f7 into pingcap:master Mar 27, 2026
35 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Mar 31, 2026
13 tasks
bitloi pushed a commit to bitloi/tidb that referenced this pull request Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants