Release 8.5 20260225 v8.5.2#67474
Release 8.5 20260225 v8.5.2#67474ClamChowderTiDB wants to merge 63 commits intopingcap:release-8.5-20260225-v8.5.2from
Conversation
X-Original-Commit: 2acac1f
X-Original-Commit: 2bee827
X-Original-Commit: da77778
X-Original-Commit: e7cd229
X-Original-Commit: 3e68831
X-Original-Commit: ac41aa0
X-Original-Commit: 1b86dc0
X-Original-Commit: 6ef54f9
X-Original-Commit: 95e9ea2
X-Original-Commit: ee93416
X-Original-Commit: c1f0d95
X-Original-Commit: 03d4d87
X-Original-Commit: 4ce4795
X-Original-Commit: 20fcc24
X-Original-Commit: 521ddcf
X-Original-Commit: 49f7b74
…1347) (pingcap#62115) X-Original-Commit: b9e2ec9
X-Original-Commit: 3dfe410
X-Original-Commit: 9637624
X-Original-Commit: 7972b48
X-Original-Commit: d6cedfb65c5009175a4a76b8e6bb09a946c8e827
X-Original-Commit: a108cf3dd784589eeb040c242abe1b7bb1b25df4
X-Original-Commit: a35eab239a35d2dda83598614c6e72c253dc4bc6
…emove some unused code. X-Original-Commit: 5dc66519fc39a75e098dd5d13f6542ddc311532a
…61090) X-Original-Commit: b6a6e7336ba663549af921e420784b99950289d5
X-Original-Commit: 38b45fb3150a3ddf50eab6b9afab2e032059618d
X-Original-Commit: dd557092ba7086d90997c9c0b5c07eaf7491ad57
|
@ClamChowderTiDB: No presubmit jobs available for pingcap/tidb@release-8.5-20260225-v8.5.2 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-br-integration-test |
|
@ClamChowderTiDB: No presubmit jobs available for pingcap/tidb@release-8.5-20260225-v8.5.2 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…ed DEPS.bzl fix_go_mod.py adds proxy.golang.org as a fallback URL for cherry-picked modules that are not in PingCap's Bazel caches. The mirror tool was overwriting these entries during `make gogenerate`, stripping the proxy URL and causing the genfiles check to fail. Two fixes: - "Reuse old mirror" branch: output all URLs from the existing entry verbatim instead of hardcoding the 4 PingCap URLs, preserving any proxy URL appended by add_proxy_urls_from_diff (e.g. kvproto). - isMirror branch: append proxy.golang.org as a 5th URL for modules that land here (e.g. ClamChowderTiDB fork modules whose DEPS.bzl entry was replaced with just a proxy URL by update_deps_bzl_entry). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ClamChowderTiDB
force-pushed
the
release-8.5-20260225-v8.5.2
branch
from
df2fdb0 to
6854b2d
Compare
…ard_count mirror.go: add proxy URL fallback to reuseOldMirror condition so that entries written by fix_go_mod.py with only a proxy.golang.org URL (e.g. ClamChowderTiDB fork modules client-go, pd/client) are preserved as-is during make gogenerate instead of being regenerated with PingCap mirror URLs that don't host the fork zips. br/pkg/task/BUILD.bazel: update shard_count 39→40 to match gazelle output. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
/test build |
|
@ClamChowderTiDB: No presubmit jobs available for pingcap/tidb@release-8.5-20260225-v8.5.2 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
maybeGetDownloadableArtifact never parsed the urls= kwarg, leaving existingMirrors always empty. This caused isMirror to regenerate every entry with 4 PingCap + proxy URLs, while the committed DEPS.bzl had either 4 PingCap-only or proxy-only entries, causing check-bazel-prepare to always fail. With urls properly parsed, existingMirrors is populated and reuseOldMirror correctly fires for all existing entries, preserving their URLs verbatim. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adding proxy as a 5th URL in the isMirror branch caused check-bazel-prepare to fail: the isMirror branch runs for all entries when existingMirrors is empty (skylarkutil was not parsing urls), generating 4 PingCap + proxy while committed DEPS.bzl has only 4 PingCap — causing a diff for every entry. The skylarkutil urls-parsing fix makes reuseOldMirror work for existing entries (both standard 4-PingCap and fork proxy-only), so isMirror only fires for genuinely new modules. For those, 4 PingCap URLs is the correct output (same as original upstream behavior). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gazelle runs before the mirror in make bazel_ci_prepare and rewrites DEPS.bzl, stripping all urls= entries (converting to sum/version format). The mirror then reads the on-disk file and sees no URLs, so existingMirrors is empty and reuseOldMirror never fires. For cherry-picked modules whose PingCap mirror URLs return 404 (kvproto, client-go, pd/client), the generated DEPS.bzl ends up with no proxy fallback, causing tazel to fail. Fix: read DEPS.bzl from git HEAD before gazelle touched it. This gives reuseOldMirror the correct URL lists (including proxy URLs added by fix_go_mod.py), so the mirror preserves those entries verbatim. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
/test pull-br-integration-test |
|
@ClamChowderTiDB: No presubmit jobs available for pingcap/tidb@release-8.5-20260225-v8.5.2 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
PingCap's pd-server v8.5.x does not implement the /pd/api/v1/admin/cluster/markers/pitr-restore-mode HTTP endpoint. SetPitrRestoreMark returned 404, causing every RESTORE DATABASE SQL statement to fail unconditionally in the brietest suite. Treat a 404 response as "endpoint not supported by this PD version", log a warning, and proceed without setting the mark. The mark is only meaningful for PD servers that actually implement it, so skipping it on older deployments is safe. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Simplify if/else to satisfy the all_revive nogo linter. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-check |
|
@ClamChowderTiDB: No presubmit jobs available for pingcap/tidb@release-8.5-20260225-v8.5.2 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test check-dev |
|
@ClamChowderTiDB: No presubmit jobs available for pingcap/tidb@release-8.5-20260225-v8.5.2 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test build |
|
@ClamChowderTiDB: No presubmit jobs available for pingcap/tidb@release-8.5-20260225-v8.5.2 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@ClamChowderTiDB: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
6 participants
Release 8.5 20260225 v8.5.2
What problem does this PR solve?
Release 8.5 20260225 v8.5.2
Issue Number: close #xxx
Problem Summary:
What changed and how does it work?
Check List
Release 8.5 20260225 v8.5.2
Release note
Release 8.5 20260225 v8.5.2
Summary by CodeRabbit
New Features
Improvements