fix(server): stop blaming Google sign-in for Antigravity session errors - #10137
Closed
rizakara wants to merge 1 commit into
Closed
fix(server): stop blaming Google sign-in for Antigravity session errors#10137rizakara wants to merge 1 commit into
rizakara wants to merge 1 commit into
Conversation
Antigravity setup runs `authenticate` and then a `session/new` probe in the same flow. When the probe fails, `safeAuthFailure` had no case for it and fell through to "Google sign-in failed. Start sign-in again." — even though Google had succeeded and `acp_token.json` was already written. Following that banner means signing out, which deletes the working token. Map an ACP request error on a `session/*` method to a message that says the sign-in worked and tells the user not to sign out. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2 tasks
Contributor
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The production change alters user-facing handling of post-authentication ACP failures in the Google credential flow and advises users not to sign out, while the accompanying test covers the targeted You can add or adjust custom eligibility rules. Learn more. |
Member
|
Superseded by #9919 (merged), which already distinguishes Antigravity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Antigravity setup runs
authenticateand then asession/newprobe in the same flow. When that probe fails,safeAuthFailurehas no case for it and falls through to "Google sign-in failed. Start sign-in again." — even though Google succeeded andacp_token.jsonwas already written. Acting on that banner means signing out, which deletes the token that was working, so the user loops forever.An
AcpRequestErroralready carries themethodit failed on, so asession/*failure can be recognised as post-authentication and reported as such.initializeis deliberately left alone: it runs beforeauthenticate, so the existing wording is still correct there.Google sign-in failed. Start sign-in again.Signed in, but Antigravity could not start a session. Retry without signing out.On the underlying failure from #9655: it is not the throwaway setup cwd, as that issue guessed. The agent's own log shows
session/newdying in the harness handshake withFailed to parse initial message: proto: (line 3:5): unknown field "cascadeid".agy_acp_server1.1.1 serializesHarnessConfig.cascade_idas lowercasecascadeid, and thelocalharness_externalbinary shipped in the same archive only acceptscascadeId. Probing that harness directly confirms it:cascadeIdparses,cascadeidproduces exactly the reported error, and Go's protojson reports unknown field names verbatim.cascade_idcomes from a session id the agent generates itself, so nothing T3 sends reaches it, and the ACP registry still lists 1.1.1 as current — there is no newer build to pin. That part is not fixable here; this PR only stops T3 from misreporting it as a sign-in failure and pushing users into a destructive sign-out.Fixes #9655
🤖 Generated with Claude Code
Note
Fix
safeAuthFailureto reportsession/*ACP errors as Antigravity session failures, not Google sign-in failuressafeAuthFailure(AntigravityAuth.ts) for ACP request errors whose method starts withsession/. When no earlier case matches, the formatter now reports sign-in succeeded but Antigravity could not start a session, advising retry without signing out.discovereddeferred can fail withAcpErrors.AcpError, and adds a test verifying the corrected failure classification after asession/newerror.Macroscope summarized 9bd867a.