fix(antigravity): distinguish session initialization auth failures - #9919
Merged
maria-rcks merged 1 commit intoSep 5, 2026
Merged
Conversation
Contributor
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The PR is a small, well-scoped correction to Antigravity’s user-facing handling of post-authentication session failures, with focused test coverage and no schema or default changes. Because it modifies production authentication behavior and error disclosure, human review is warranted. You can add or adjust custom eligibility rules. Learn more. |
github-actions Bot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Sep 5, 2026
## What's Changed * fix(web): align tool disclosure chevrons with expanded state by @maria-rcks in pingdotgg/t3code#9935 * fix(antigravity): distinguish session initialization auth failures by @maria-rcks in pingdotgg/t3code#9919 * fix(cursor): cache successful model discovery between refreshes by @maria-rcks in pingdotgg/t3code#9918 * fix(opencode): revert from the first removed assistant message by @maria-rcks in pingdotgg/t3code#9924 * fix(web): resume imported custom-provider threads by @juliusmarminge in pingdotgg/t3code#10184 * test(web): cancel pending highlight fixture frames during cleanup by @juliusmarminge in pingdotgg/t3code#10188 **Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260905.1289...v0.0.39-nightly.20260905.1290 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260905.1290
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
antigravity session initialization failures after authentication currently appear as generic sign-in failures. identify ACP session/new internal errors as a failure to initialize a session or load models, without exposing the provider error payload.
verified with 19 focused auth tests, server typecheck, and scoped lint and formatting checks. the focused auth test output is shown below. this improves diagnostics; it does not fix the upstream ACP failure.
relates to #9655.
implemented with gpt-6-astra in codex.
Note
Low Risk
User-facing error strings only in Antigravity auth; no changes to sign-in, session, or credential handling logic.
Overview
After Google sign-in succeeds, Antigravity failures during
session/new(ACP internal error-32603) no longer surface as generic “Google sign-in failed” messages.safeAuthFailurenow maps that case to: “Antigravity authenticated, but could not initialize a session or load models.” The raw providererrorMessage(e.g. redirect URLs or other payload) is not shown to users.A focused auth test simulates auth succeeding then
session/newfailing, and asserts the new copy, no leaked callback details, unchanged model catalog, and clean process shutdown. The test harness types thediscovereddeferred so it can fail withAcpRequestErrorlike production.Reviewed by Cursor Bugbot for commit fa71942. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix
AntigravityAuth.safeAuthFailureto distinguishsession/newerrorsMaps ACP request errors from
session/newwith code-32603to the message "Antigravity authenticated, but could not initialize a session or load models." instead of the generic auth failure message. UpdatesmakeAuthTestHarnessto propagate discovery failures and adds a test covering the post-authentication session failure path.Macroscope summarized fa71942.