Skip to content

fix(antigravity): distinguish session initialization auth failures - #9919

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:fix/antigravity-post-auth-error-9655
Sep 5, 2026
Merged

fix(antigravity): distinguish session initialization auth failures#9919
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:fix/antigravity-post-auth-error-9655

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

antigravity session initialization failures after authentication currently appear as generic sign-in failures. identify ACP session/new internal errors as a failure to initialize a session or load models, without exposing the provider error payload.

verified with 19 focused auth tests, server typecheck, and scoped lint and formatting checks. the focused auth test output is shown below. this improves diagnostics; it does not fix the upstream ACP failure.

19 focused antigravity auth tests passing

relates to #9655.

implemented with gpt-6-astra in codex.


Note

Low Risk
User-facing error strings only in Antigravity auth; no changes to sign-in, session, or credential handling logic.

Overview
After Google sign-in succeeds, Antigravity failures during session/new (ACP internal error -32603) no longer surface as generic “Google sign-in failed” messages.

safeAuthFailure now maps that case to: “Antigravity authenticated, but could not initialize a session or load models.” The raw provider errorMessage (e.g. redirect URLs or other payload) is not shown to users.

A focused auth test simulates auth succeeding then session/new failing, and asserts the new copy, no leaked callback details, unchanged model catalog, and clean process shutdown. The test harness types the discovered deferred so it can fail with AcpRequestError like production.

Reviewed by Cursor Bugbot for commit fa71942. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix AntigravityAuth.safeAuthFailure to distinguish session/new errors

Maps ACP request errors from session/new with code -32603 to the message "Antigravity authenticated, but could not initialize a session or load models." instead of the generic auth failure message. Updates makeAuthTestHarness to propagate discovery failures and adds a test covering the post-authentication session failure path.

Macroscope summarized fa71942.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 5, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The PR is a small, well-scoped correction to Antigravity’s user-facing handling of post-authentication session failures, with focused test coverage and no schema or default changes. Because it modifies production authentication behavior and error disclosure, human review is warranted.

You can add or adjust custom eligibility rules. Learn more.

@maria-rcks
maria-rcks merged commit 6349a0e into pingdotgg:main Sep 5, 2026
23 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 5, 2026
## What's Changed
* fix(web): align tool disclosure chevrons with expanded state by @maria-rcks in pingdotgg/t3code#9935
* fix(antigravity): distinguish session initialization auth failures by @maria-rcks in pingdotgg/t3code#9919
* fix(cursor): cache successful model discovery between refreshes by @maria-rcks in pingdotgg/t3code#9918
* fix(opencode): revert from the first removed assistant message by @maria-rcks in pingdotgg/t3code#9924
* fix(web): resume imported custom-provider threads by @juliusmarminge in pingdotgg/t3code#10184
* test(web): cancel pending highlight fixture frames during cleanup by @juliusmarminge in pingdotgg/t3code#10188


**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260905.1289...v0.0.39-nightly.20260905.1290

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260905.1290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant