Skip to content

test(mobile): seed snoozed showcase threads - #5155

Merged
maria-rcks merged 3 commits into
pingdotgg:mainfrom
PixPMusic:t3code/add-snoozed-thread-test-data
Aug 12, 2026
Merged

test(mobile): seed snoozed showcase threads#5155
maria-rcks merged 3 commits into
pingdotgg:mainfrom
PixPMusic:t3code/add-snoozed-thread-test-data

Conversation

@PixPMusic

@PixPMusic PixPMusic commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

What Changed

  • seed two completed showcase threads with distinct future snooze times
  • persist snoozed_until and snoozed_at in the generated showcase projection data
  • keep the deep-linked primary thread and blocked, working, and settled examples unsnoozed
  • cover the fixture shape with focused regression assertions

Why

The mobile screenshot harness generates realistic thread data, but it did not include snoozed threads. That left the Snoozed shelf absent from generated screenshots and from disposable mobile test fixtures based on the showcase seeder.

UI Changes

No production UI code changed. Generated thread-list captures now include a collapsed Snoozed (2) shelf backed by two expandable rows with different wake times.

Verification

  • pnpm exec vp test run scripts/mobile-showcase.test.ts (19 tests)
  • pnpm exec vp run --filter @t3tools/scripts typecheck
  • pnpm exec vp lint --report-unused-disable-directives scripts/mobile-showcase-environment.ts scripts/mobile-showcase.test.ts
  • pnpm exec vp fmt --check scripts/mobile-showcase-environment.ts scripts/mobile-showcase.test.ts
  • git diff --check

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • No production UI changed, so no before/after screenshots are needed

Model: GPT-5.6 Sol | Harness: Codex in T3 Code


Note

Low Risk
Changes are limited to showcase seed data and tests; no production runtime or UI behavior is modified.

Overview
Extends the mobile screenshot/showcase seeder so generated thread lists can include a Snoozed shelf, without touching production UI.

insertThread now accepts optional snoozeMinutes and writes snoozed_until / snoozed_at on projection_threads (derived from seed time). hasSeedableSchema waits for those columns before seeding. Fixture data adds snoozeMinutes on hydration-haikus (90m), a new patient-penguins thread (8h snooze), and bumps the showcase thread count 8 → 9.

mobile-showcase.test.ts asserts exactly two snoozed, completed, non-settled threads with distinct wake offsets, and that the deep-linked primary thread stays unsnoozed.

Reviewed by Cursor Bugbot for commit 553963a. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Seed snoozed showcase threads in the mobile showcase environment

  • Adds snoozeMinutes to the insertThread function in mobile-showcase-environment.ts, writing snoozed_until and snoozed_at into projection_threads when provided (NULLs otherwise).
  • Seeds two snoozed threads (hydration-haikus, patient-penguins) and adds a new patient-penguins entry, bringing the total from 8 to 9 showcase threads.
  • hasSeedableSchema now checks for the presence of snoozed_until and snoozed_at columns in projection_threads before allowing seeding.
  • Updates tests in mobile-showcase.test.ts to assert the new thread count and validate snooze properties.

Macroscope summarized 553963a.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cd15ce75-d89d-4840-92ad-fc0e7f26f321

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Jul 31, 2026
Comment thread scripts/mobile-showcase-environment.ts
@macroscopeapp

macroscopeapp Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 490b149

Test-only changes to mobile showcase seeding scripts. Adds seed data for snoozed threads and corresponding test assertions with no production runtime impact.

You can customize Macroscope's approvability policy. Learn more.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 31, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review July 31, 2026 23:40

Dismissing prior approval to re-evaluate 490b149

@PixPMusic
PixPMusic force-pushed the t3code/add-snoozed-thread-test-data branch from 490b149 to ce962f9 Compare August 3, 2026 16:03
@PixPMusic
PixPMusic force-pushed the t3code/add-snoozed-thread-test-data branch from ce962f9 to 553963a Compare August 10, 2026 07:59
@maria-rcks
maria-rcks merged commit e3a9c25 into pingdotgg:main Aug 12, 2026
16 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 12, 2026
## What's Changed
* fix(web): align update toast release notes link by @t3-code[bot] in pingdotgg/t3code#6322
* fix(web): render tooltips above dropdowns by @extoci in pingdotgg/t3code#6241
* fix(web): open modified PR clicks in browser by @t3-code[bot] in pingdotgg/t3code#6278
* Fix mobile command popover glass rendering by @juliusmarminge in pingdotgg/t3code#6370
* test(mobile): seed snoozed showcase threads by @PixPMusic in pingdotgg/t3code#5155
* fix(web): preserve appearance mode when changing themes by @extoci in pingdotgg/t3code#6343
* feat(connect): deregister account environments from any client by @StiensWout in pingdotgg/t3code#4844
* feat(web): pull request surfaces — filters & qualifiers, all-server listing, update branch, reactions, in-place editing, smarter diffs by @Bil0000 in pingdotgg/t3code#6039


**Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260812.1077...v0.0.34-nightly.20260812.1079

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260812.1079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants