test(mobile): seed snoozed showcase threads - #5155
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 490b149 Test-only changes to mobile showcase seeding scripts. Adds seed data for snoozed threads and corresponding test assertions with no production runtime impact. You can customize Macroscope's approvability policy. Learn more. |
Dismissing prior approval to re-evaluate 490b149
490b149 to
ce962f9
Compare
ce962f9 to
553963a
Compare
## What's Changed * fix(web): align update toast release notes link by @t3-code[bot] in pingdotgg/t3code#6322 * fix(web): render tooltips above dropdowns by @extoci in pingdotgg/t3code#6241 * fix(web): open modified PR clicks in browser by @t3-code[bot] in pingdotgg/t3code#6278 * Fix mobile command popover glass rendering by @juliusmarminge in pingdotgg/t3code#6370 * test(mobile): seed snoozed showcase threads by @PixPMusic in pingdotgg/t3code#5155 * fix(web): preserve appearance mode when changing themes by @extoci in pingdotgg/t3code#6343 * feat(connect): deregister account environments from any client by @StiensWout in pingdotgg/t3code#4844 * feat(web): pull request surfaces — filters & qualifiers, all-server listing, update branch, reactions, in-place editing, smarter diffs by @Bil0000 in pingdotgg/t3code#6039 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260812.1077...v0.0.34-nightly.20260812.1079 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260812.1079
What Changed
snoozed_untilandsnoozed_atin the generated showcase projection dataWhy
The mobile screenshot harness generates realistic thread data, but it did not include snoozed threads. That left the Snoozed shelf absent from generated screenshots and from disposable mobile test fixtures based on the showcase seeder.
UI Changes
No production UI code changed. Generated thread-list captures now include a collapsed
Snoozed (2)shelf backed by two expandable rows with different wake times.Verification
pnpm exec vp test run scripts/mobile-showcase.test.ts(19 tests)pnpm exec vp run --filter @t3tools/scripts typecheckpnpm exec vp lint --report-unused-disable-directives scripts/mobile-showcase-environment.ts scripts/mobile-showcase.test.tspnpm exec vp fmt --check scripts/mobile-showcase-environment.ts scripts/mobile-showcase.test.tsgit diff --checkChecklist
Model: GPT-5.6 Sol | Harness: Codex in T3 Code
Note
Low Risk
Changes are limited to showcase seed data and tests; no production runtime or UI behavior is modified.
Overview
Extends the mobile screenshot/showcase seeder so generated thread lists can include a Snoozed shelf, without touching production UI.
insertThreadnow accepts optionalsnoozeMinutesand writessnoozed_until/snoozed_atonprojection_threads(derived from seed time).hasSeedableSchemawaits for those columns before seeding. Fixture data addssnoozeMinuteson hydration-haikus (90m), a new patient-penguins thread (8h snooze), and bumps the showcase thread count 8 → 9.mobile-showcase.test.tsasserts exactly two snoozed, completed, non-settled threads with distinct wake offsets, and that the deep-linked primary thread stays unsnoozed.Reviewed by Cursor Bugbot for commit 553963a. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Seed snoozed showcase threads in the mobile showcase environment
snoozeMinutesto theinsertThreadfunction in mobile-showcase-environment.ts, writingsnoozed_untilandsnoozed_atintoprojection_threadswhen provided (NULLs otherwise).hydration-haikus,patient-penguins) and adds a newpatient-penguinsentry, bringing the total from 8 to 9 showcase threads.hasSeedableSchemanow checks for the presence ofsnoozed_untilandsnoozed_atcolumns inprojection_threadsbefore allowing seeding.Macroscope summarized 553963a.