Skip to content

fix(web): open modified PR clicks in browser - #6278

Merged
maria-rcks merged 1 commit into
mainfrom
fix/pr-modifier-opens-browser
Aug 12, 2026
Merged

fix(web): open modified PR clicks in browser#6278
maria-rcks merged 1 commit into
mainfrom
fix/pr-modifier-opens-browser

Conversation

@t3-code

@t3-code t3-code Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

summary

  • open pull request links in the external browser on cmd+click or ctrl+click
  • preserve the built-in pull request view for ordinary clicks
  • apply the behavior through the shared handler used by sidebar, toolbar, and markdown links

testing

  • vp test apps/web/src/lib/openPullRequestLink.test.ts
  • tsgo --noEmit -p apps/web/tsconfig.json
  • vp lint apps/web/src/lib/openPullRequestLink.ts apps/web/src/lib/openPullRequestLink.test.ts
  • vp fmt --check apps/web/src/lib/openPullRequestLink.ts apps/web/src/lib/openPullRequestLink.test.ts

request provenance


Note

Low Risk
Small UX change to shared PR link click handling with unit tests; no auth, data, or security-sensitive logic.

Overview
Cmd/Ctrl-click on pull request links now opens them in the external browser, while ordinary clicks still use the in-app pull request view.

Adds shouldOpenPullRequestExternally and wires it into useOpenChangeRequestLink so modified clicks skip in-app handling and fall through to the browser. Behavior applies everywhere that shared handler is used (sidebar, toolbar, and markdown links).

Reviewed by Cursor Bugbot for commit a8a6b1d. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Allow modified PR link clicks to open in the browser instead of in-app

Adds shouldOpenPullRequestExternally to openPullRequestLink.ts, which returns true when metaKey or ctrlKey is held. The useOpenChangeRequestLink hook now checks this early and returns false without performing internal navigation, letting the browser handle the click normally.

Macroscope summarized a8a6b1d.

Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Aug 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 11.3 KiB 11.3 KiB −25 B (−0.2%) 15.1 KiB
Codex Thread snapshot wire 5.5 KiB 5.5 KiB +1 B (+0.0%) 7.3 KiB
Codex Live turn WebSocket wire 5.9 KiB 5.9 KiB −26 B (−0.4%) 7.8 KiB
Codex Live turn WebSocket decoded 49.7 KiB 49.7 KiB 0 B (0.0%) 66.4 KiB
Codex Live turn messages 16 16 0 (0.0%) 21
Claude Total thread wire 11.3 KiB 11.3 KiB −3 B (−0.0%) 15.1 KiB
Claude Thread snapshot wire 5.5 KiB 5.5 KiB −5 B (−0.1%) 7.3 KiB
Claude Live turn WebSocket wire 5.9 KiB 5.9 KiB +2 B (+0.0%) 7.8 KiB
Claude Live turn WebSocket decoded 50.6 KiB 50.6 KiB 0 B (0.0%) 66.4 KiB
Claude Live turn messages 16 16 0 (0.0%) 21

Baseline: 5a84614 · PR result: a8a6b1d · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 94.6 KiB
  • Claude decoded thread snapshot: 95.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeapp Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved a8a6b1d

Simple UX fix adding standard web behavior for cmd/ctrl+click to open PR links in the browser. The change is minimal, well-tested, and follows expected conventions.

You can customize Macroscope's approvability policy. Learn more.

@maria-rcks
maria-rcks merged commit 8d24b51 into main Aug 12, 2026
16 checks passed
@maria-rcks
maria-rcks deleted the fix/pr-modifier-opens-browser branch August 12, 2026 18:32
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 12, 2026
## What's Changed
* fix(web): align update toast release notes link by @t3-code[bot] in pingdotgg/t3code#6322
* fix(web): render tooltips above dropdowns by @extoci in pingdotgg/t3code#6241
* fix(web): open modified PR clicks in browser by @t3-code[bot] in pingdotgg/t3code#6278
* Fix mobile command popover glass rendering by @juliusmarminge in pingdotgg/t3code#6370
* test(mobile): seed snoozed showcase threads by @PixPMusic in pingdotgg/t3code#5155
* fix(web): preserve appearance mode when changing themes by @extoci in pingdotgg/t3code#6343
* feat(connect): deregister account environments from any client by @StiensWout in pingdotgg/t3code#4844
* feat(web): pull request surfaces — filters & qualifiers, all-server listing, update branch, reactions, in-place editing, smarter diffs by @Bil0000 in pingdotgg/t3code#6039


**Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260812.1077...v0.0.34-nightly.20260812.1079

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260812.1079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant