fix(acp): keep unknown approvals actionable - #5430
Merged
Merged
Conversation
github-actions
Bot
added
vouch:trusted
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Contributor
ApprovabilityVerdict: Approved 2634697 Straightforward bug fix that remaps unknown ACP permission kinds from "unknown" to "dynamic_tool_call", making previously non-actionable approvals actionable in the UI. Changes are minimal (2 production lines) with corresponding test coverage. You can customize Macroscope's approvability policy. Learn more. |
github-actions Bot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Aug 7, 2026
## What's Changed * fix(web): clarify auto permission fallback by @t3-code[bot] in pingdotgg/t3code#5431 * fix(acp): keep unknown approvals actionable by @t3-code[bot] in pingdotgg/t3code#5430 * fix(mobile): stop thread messages reading through pending cards by @carlosricojr in pingdotgg/t3code#5450 * fix(web): align composer inline chips with prompt text by @StiensWout in pingdotgg/t3code#5495 * fix(web): clear woke state on explicit thread actions by @StiensWout in pingdotgg/t3code#5486 **Full Changelog**: pingdotgg/t3code@v0.0.32-nightly.20260806.1015...v0.0.32-nightly.20260806.1018 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.32-nightly.20260806.1018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
dynamic_tool_callwhy
Cursor and Grok can send permission kinds outside our known set. Those requests were projected as pending but omitted by the client, leaving an Approval status with no card to resolve.
ui changes
No visual styling changes. Previously hidden generic approvals now use the existing command approval card.
checks
git diff --checkModel: OpenAI (API model not exposed). Harness: T3bot.
Note
Map unknown ACP permission kinds to
dynamic_tool_callinstead ofunknownUnrecognized ACP permission kinds previously mapped to
'unknown'incanonicalRequestTypeFromAcpKind, making those approvals non-actionable. The default case in AcpCoreRuntimeEvents.ts now returns'dynamic_tool_call', and theAcpCanonicalRequestTypealias is updated to match. On the web side,dynamic_tool_callrequest types are derived asrequestKind: 'command'pending approvals, so they surface correctly in the UI.Macroscope summarized 2634697.
Note
Low Risk
Small mapping change in ACP event projection with tests; no auth or data-path changes.
Overview
Unrecognized ACP permission kinds (e.g. from Cursor/Grok) are no longer emitted as
unknownruntime approvals.canonicalRequestTypeFromAcpKindnow defaults todynamic_tool_call, while execute/read/edit/delete/move mappings stay the same.That lets the web client treat these like other pending approvals (via the existing command approval card) instead of showing Approval with nothing to act on.
Tests cover generic kinds on request.opened / request.resolved and
derivePendingApprovalsfordynamic_tool_callpayloads.Reviewed by Cursor Bugbot for commit 2634697. Bugbot is set up for automated code reviews on this repo. Configure here.