fix(web): align composer inline chips with prompt text - #5495
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved b727ac1 Pure CSS alignment fix - changes vertical alignment values and adds a small label offset class for inline chips. No logic or behavior changes, only visual positioning adjustments. You can customize Macroscope's approvability policy. Learn more. |
Dismissing prior approval to re-evaluate 7865726
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7865726. Configure here.
## What's Changed * fix(web): clarify auto permission fallback by @t3-code[bot] in pingdotgg/t3code#5431 * fix(acp): keep unknown approvals actionable by @t3-code[bot] in pingdotgg/t3code#5430 * fix(mobile): stop thread messages reading through pending cards by @carlosricojr in pingdotgg/t3code#5450 * fix(web): align composer inline chips with prompt text by @StiensWout in pingdotgg/t3code#5495 * fix(web): clear woke state on explicit thread actions by @StiensWout in pingdotgg/t3code#5486 **Full Changelog**: pingdotgg/t3code@v0.0.32-nightly.20260806.1015...v0.0.32-nightly.20260806.1018 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.32-nightly.20260806.1018

Summary
The Prompt font preview's inline skill pill sat low relative to surrounding text when custom prompt fonts were used. The first pass corrected the outer pill placement; this follow-up corrects the smaller label glyph position inside that pill.
The shared composer inline-token wrapper uses a small em-based negative vertical alignment. The smaller skill label gets a scoped em-based relative offset so its glyph bottom aligns with surrounding prompt text without moving the pill box or changing the editor's line height; shared file and terminal-context labels retain their existing positioning.
Validation
vp fmt --check apps/web/src/components/ComposerPromptEditor.tsxvp lint apps/web/src/components/ComposerPromptEditor.tsx --report-unused-disable-directivesvp fmt --check apps/web/src/components/composerInlineChip.tsvp lint apps/web/src/components/composerInlineChip.ts --report-unused-disable-directivesvp run --filter @t3tools/web typecheckvp run --filter @t3tools/web buildBrowser verification at desktop and 390px widths: the label bottom moved from
619.25pxto621.05px, matching surrounding text at621.06px; the pill box stayed unchanged and the narrow layout had no clipping.The label offset is scoped to composer skill chips; shared chat and terminal label styles remain unchanged.
Visual evidence:
The focused Vitest command was attempted after
vp i, but the runner failed before test execution withTypeError: Cannot read properties of undefined (reading 'config'); the same runner-stage failure reproduced on an unrelated web test.Model/harness: Codex (GPT-5.6-Luna) via T3 Code.
Note
Low Risk
CSS-only presentation tweaks in the composer prompt editor; no behavior, auth, or data changes.
Overview
Fixes composer inline chips (file mentions, skills, terminal context) sitting low relative to surrounding prompt text, especially with custom prompt fonts.
Lexical decorator wrappers for those chips now use
align-[-0.125em]instead ofalign-middleso the pill aligns with the prompt line without changing line height. Skill chips additionally getCOMPOSER_INLINE_SKILL_CHIP_LABEL_CLASS_NAMEwithrelative top-[0.15em]so the smaller label glyphs line up with adjacent text while the pill box stays put.Reviewed by Cursor Bugbot for commit b727ac1. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix vertical alignment of inline chips in the composer prompt editor
Changes the vertical alignment of mention, skill, and terminal context chips from
align-middletoalign-[-0.125em]so chips sit flush with surrounding prompt text. Also adds a newCOMPOSER_INLINE_SKILL_CHIP_LABEL_CLASS_NAMEconstant in composerInlineChip.ts that applies an additionalrelative top-[0.15em]offset to correct glyph positioning within skill chip labels.Macroscope summarized b727ac1.