Skip to content

feat(ws): enable websocket log streaming#78

Merged
mcollina merged 25 commits intoplatformatic:mainfrom
rozzilla:feat/ws/enable-websocket-log-streaming
May 26, 2025
Merged

feat(ws): enable websocket log streaming#78
mcollina merged 25 commits intoplatformatic:mainfrom
rozzilla:feat/ws/enable-websocket-log-streaming

Conversation

@rozzilla
Copy link
Copy Markdown
Contributor

@rozzilla rozzilla commented Apr 25, 2025 •
edited
Loading

Fixes #37

@rozzilla rozzilla mentioned this pull request Apr 25, 2025
Closed
@rozzilla rozzilla force-pushed the feat/ws/enable-websocket-log-streaming branch from 9f56224 to 5268489 Compare April 30, 2025 15:17
@rozzilla
feat(ws): enable websocket log streaming
62c1617 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>

update

Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>

update

Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla rozzilla force-pushed the feat/ws/enable-websocket-log-streaming branch from 5268489 to 62c1617 Compare May 14, 2025 09:35
rozzilla and others added 13 commits May 14, 2025 11:40
@rozzilla
feat(backend): use http
91ce33f 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@mcollina
fixed websockets
4ec77f8 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
fixup
987b5b9 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@rozzilla
update
5f2d223 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
update
7836acf 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
update
cb20891 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
cleanup
b3b04df 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
update
6a52431 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
update
d8888c6 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
fix
31e92d5 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
update
a3933f8 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
update
7193b3f 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
fix
5d3f8c8 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla rozzilla marked this pull request as ready for review May 15, 2025 15:04
@rozzilla
Copy link
Copy Markdown
Contributor Author

rozzilla commented May 15, 2025

@mcollina this is now working on the frontend 👍🏼

mcollina
mcollina requested changes May 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there tests for the websocket route?

Also, I would recommend splitting the routes into multiple files.

rozzilla
rozzilla commented May 15, 2025
View reviewed changes
web/backend/routes/root.ts Outdated
getLogsFromReadable(await api.getRuntimeAllLogsStream(pid), log))
typedFastify.get<{ Params: PidParam }>('/runtimes/:pid/logs/ws', {
schema: { params: pidParamSchema, hide: true },
websocket: true
Copy link
Copy Markdown
Contributor Author

@rozzilla rozzilla May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove it once this is released

rozzilla added 2 commits May 15, 2025 18:06
@rozzilla
fixup
e3bfa8e 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
chore(test): add ws test
9b91f33 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
Copy link
Copy Markdown
Contributor Author

rozzilla commented May 15, 2025

Are there tests for the websocket route?

@mcollina done on 9b91f33

Also, I would recommend splitting the routes into multiple files.

Good point. To reduce the amount of changes in this PR, I would like to do it in a follow-up one, if it's not a problem 😉

@rozzilla rozzilla requested a review from mcollina May 15, 2025 16:22
mcollina
mcollina requested changes May 16, 2025
View reviewed changes
rozzilla added 4 commits May 16, 2025 18:12
@rozzilla
update
b6e7f70 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
feat(backend): add wsSendAsync method
d2f6a0b 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
chore(frontend): remove logs
d1029bf 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
chore(test): update
37bd0bf 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla rozzilla requested a review from mcollina May 19, 2025 07:40
@rozzilla
split
fd85b4f 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
Copy link
Copy Markdown
Contributor Author

rozzilla commented May 19, 2025

Are there tests for the websocket route?

Also, I would recommend splitting the routes into multiple files.

@mcollina I took some time also to split the routes in multiple files

rozzilla added 4 commits May 19, 2025 10:06
@rozzilla
cleanup
774249d 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
cleanup
1487be6 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
fix
a94e753 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
@rozzilla
update
ba72657 
Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
mcollina
mcollina approved these changes May 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 53c9bc8 into platformatic:main May 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support live runtime logs

2 participants

@rozzilla @mcollina