Fix Bypass filtering on the groups assignment option#291
Merged
Conversation
Lainow
force-pushed
the
fix-escalade-group-list
branch
from
6edeb5c to
32a42f3
Compare
Contributor
|
@Lainow can you rebase |
stonebuzz
approved these changes
Feb 28, 2025
Contributor
|
Can you check with the customer that it's working properly? |
Rom1-B
requested changes
Feb 28, 2025
| 'is_assign' => 1 | ||
| ]; | ||
| if ($config->fields['use_filter_assign_group']) { | ||
| if ($config->fields['use_filter_assign_group'] && !$user_config->fields['use_filter_assign_group']) { |
Contributor
There was a problem hiding this comment.
The fix seems correct, but I notice that the name use_filter_assign_group is confusing because it is the same in both the global configuration and the user configuration, yet the behavior is opposite:
- In the global configuration: "Enable filtering on the groups assignment"
- In the user configuration: "Bypass filtering on the groups assignment"
I suggest renaming the user-level option to bypass_filter_assign_group to avoid confusion.
Rom1-B
requested changes
Mar 3, 2025
Contributor
Author
That's good |
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Contributor
|
@Lainow can you validate with customer? |
Contributor
Author
It's ok |
Rom1-B
approved these changes
Mar 10, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Fixed
Bypass filtering on the groups assignmentoption because it filtered which groups to escalate to even though the user was supposed to bypass filteringScreenshots (if appropriate):