Conversation
|
Upgrade to alpha.5 involves and api change in the builder, separating the |
|
Upgrade to alpha.6 involves a deprecation of the tracing feature and performance improvements. |
|
We can probably hard code the max_rec/max_sent values if we are not already doing that today. No need to send those values via the client. |
|
Matt had attempted this upgrade in the past, but encountered performance regression back then and we created this ticket: #47 Can you benchmark on ios/wasm before/after? |
yes. In any case even with a performance degradation i think it makes sense to use the up to date work and just communicate that regression to their team. Reading the change log it seams like the performance regressions were reduced in a number of dimensions in alpha.6 and alpha.7 |
41eb8a7 to
ab5675c
Compare
|
There is one part of this i am battling right now around the |
8913cef to
3f71120
Compare
|
To bring this across the line we would need to integrate tlsn into the manifest flow we have now |
|
@0xJepsen are you interested in finishing the tasks here this week? |
|
Yeah i need to meet with @mattes to understand how we would incorporate this into the manifest |
|
That's fair. I think we are likely going to lean to decoupling the manifests used for TEEs and circuits/MPC a bit. However, we should discuss more |
|
imo the right place to start is to make origo manifest work with upgraded TLSN, that's the simplest and most stable. |
e72b94a to
e9565d2
Compare
bce2684 to
2952842
Compare
TLSN related changes:
Cleaning Efforts
|
| pub manifest_hash: Vec<u8>, | ||
| } | ||
|
|
||
| pub async fn verify<T: Serialize>( |
There was a problem hiding this comment.
verify method is common for all modes in client
|
Logic for TLSN selective disclosure. flow is pretty similar to TLSN vanilla example flow:
|
|
looks like this might need a rebase |
1250a58 to
7269282
Compare
|
CI passes, all review changes are done. Merging!! |
This PR upgrades tlsn to alpha7