Resource packs are broken

[sylvrs]

Issue description

While messing around with AsyncTasks, I found out that ResourcePacks have been broken, every texture pack that I tried(yes I downloaded them via Google Chrome just to double check) always gave me the same result(manifest.json not found). The manifest was in all of them, yet none were found? I tried both zip and mcpack(although they are the same thing), yet failed.

Steps to reproduce the issue

1. ...
2. ...

OS and versions

• PocketMine-MP: 83471aa
• PHP: 7.0.3
• Server OS: Windows 10
• Game version: v1.1.0.55

Plugins

• Test on a clean server without plugins: is the issue reproducible without any plugins loaded? Yes, I removed all of the plugins to double check.

If the issue is not reproducible without plugins:

• Have you asked for help on our forums before creating an issue?
• Can you provide sample, minimal reproducing code for the issue? If so, paste it in the bottom section
• Paste your list of plugins here (use the 'plugins' command in PocketMine-MP)

Crashdump, backtrace or other files

[19:36:43] [Server thread/CRITICAL]: InvalidStateException: "Could not load reso
urce pack from C:\Users\Matt\Documents\Test Server\resource_packs\\SuchPvP16x.mc
pack: manifest.json not found" (EXCEPTION) in "src/pocketmine/resourcepacks/Zipp
edResourcePack" at line 79
[19:36:43] [Server thread/DEBUG]: #0 src/pocketmine/resourcepacks/ResourcePackMa
nager(89): pocketmine\resourcepacks\ZippedResourcePack->__construct(string C:\Us
ers\Matt\Documents\Test Server\resource_packs\\SuchPvP16x.mcpack)
[19:36:43] [Server thread/DEBUG]: #1 src/pocketmine/Server(1591): pocketmine\res
ourcepacks\ResourcePackManager->__construct(pocketmine\Server object, string C:\
Users\Matt\Documents\Test Server\resource_packs\)
[19:36:43] [Server thread/DEBUG]: #2 src/pocketmine/PocketMine(511): pocketmine\
Server->__construct(BaseClassLoader object, pocketmine\utils\MainLogger object,
string C:\Users\Matt\Documents\Test Server\, string C:\Users\Matt\Documents\Test
 Server\, string C:\Users\Matt\Documents\Test Server\plugins\)
[19:36:43] [Server thread/DEBUG]: Successfully loaded 0 resource packs
[19:36:43] [Server thread/INFO]: Loading DevTools v1.11.3
[19:36:43] [Server thread/INFO]: Enabling DevTools v1.11.3
[19:36:43] [Server thread/INFO]: Loading source plugin TestPlugin v1
[19:36:43] [Server thread/INFO]: [DevTools] Registered folder plugin loader
[19:36:43] [Server thread/INFO]: Preparing level "buildWorld"
[19:36:43] [Server thread/INFO]: Enabling TestPlugin v3
[19:36:43] [Server thread/INFO]: [TestPlugin] The core has been enabled!
[19:36:43] [Server thread/INFO]: Starting GS4 status listener
nager(89): pocketmine\resourcepacks\ZippedResourcePack->__construct(string C:\Users\Matt\Documents\Test Server\resource_packs\\SuchPvP16x.mcpack)
[19:36:43] [Server thread/DEBUG]: #1 src/pocketmine/Server(1591): pocketmine\resourcepacks\ResourcePackManager->__construct(pocketmine\Server object, string C:\Users\Matt\Documents\T
est Server\resource_packs\)
[19:36:43] [Server thread/DEBUG]: #2 src/pocketmine/PocketMine(511): pocketmine\Server->__construct(BaseClassLoader object, pocketmine\utils\MainLogger object, string C:\Users\Matt\D
ocuments\Test Server\, string C:\Users\Matt\Documents\Test Server\, string C:\Users\Matt\Documents\Test Server\plugins\)

[dktapps]

Mind linking a sample resource pack that has this problem? I have resource packs on my development server that have been there for months and I have no trouble with those.

[dries-c]

same problem

[dries-c]

http://mcpedl.com/faithful-pe/
32x32

[dktapps]

Works fine for me.

[dries-c]

i have force resource packs turned off

[moskadev]

Same issue. Is the compression’s system on macOS is different as Windows (this is happening when I’m trying to ZIP a pack) ?

[dries-c]

i tested on macosx

[dktapps]

@SuperMaXAleX do you have any specific resource pack that this can be reproduced with? I tried the Faithful one above on three different systems and had no issue.

[moskadev]

There isn't specific resource pack. This is happening when you are compressing a pack with macOS and install it on your server, you have got this problem.
If you downloaded a pack with the format .mcpack or .zip who has been compressed on Windows, this will work.
I suppose when something is compressed on macOS, files directories are different.

[dktapps]

Could you send me a link to one of these resource packs compressed on Mac that you're having problems with?

[moskadev]

No problem

[moskadev]

Very basic resource pack : https://www.dropbox.com/s/z1rixxcft08obkv/stained-glass.zip?dl=0

[dktapps]

Ah, the problem is obvious straight away.

The manifest.json must be in the root of the resource-pack zip, but your pack has everything inside its own folder. Don't select and compress the folder, you should enter the folder, select all the files and then create the zip.