fix(core): floor adaptive precision at float resolution to let springs settle on sub-precision drift#2520
Merged
Conversation
…s settle on sub-precision drift
🦋 Changeset detectedLatest commit: 6f96c9c The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2208.
Summary
When a caller passes a target value to
controller.start()that differs from the current value by less than the smallest difference doubles can represent at that magnitude, the spring entered animation with an adaptive precision the math could never satisfy — so the animation never finished and the awaitedstart()promise never resolved. The original repro is layout code computing positions withMath.cos(Math.PI / 2): JS returns6.12e-17instead of0, so a "logical160" target arrives as159.99999999999997.isEqual(160, 159.99999999999997)isfalse, the spring sees a non-zero distance, and the adaptive precision (|to - from| * 0.001 ≈ 3.5e-18) is unrepresentable. The spring drifts forever;frameLoopnever goes idle.The fix floors the adaptive default at
max(|to|, |from|, 1) * Number.EPSILON— the smallest meaningful precision for the values being animated. Caller-suppliedconfig.precisionand thefrom === tofast path are unchanged.Repro